-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded OpenXR Layer Support #1348
Open
rblenkinsopp
wants to merge
11
commits into
develop
Choose a base branch
from
oxr-embedded-api-layer
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGrayUL
reviewed
Nov 24, 2022
Packages/Tracking/OpenXR/API Layer/HandTrackingApiLayerFeature.cs
Outdated
Show resolved
Hide resolved
MattGrayUL
reviewed
Nov 24, 2022
Packages/Tracking/OpenXR/API Layer/HandTrackingApiLayerFeature.cs
Outdated
Show resolved
Hide resolved
MattGrayUL
reviewed
Nov 24, 2022
Packages/Tracking/OpenXR/API Layer/HandTrackingApiLayerFeature.cs
Outdated
Show resolved
Hide resolved
rblenkinsopp
force-pushed
the
oxr-embedded-api-layer
branch
from
November 24, 2022 17:00
a19923e
to
3df11d3
Compare
I've resolved the non-naming-based issues with this. |
We agreed to hold off on merging this till Unity has a default loader which supports embedded layers (>= 1.0.25); this will remain in draft until then. |
This is at best a proxy for the loader version, which can't be directly checked, hence is just a warning.
rblenkinsopp
force-pushed
the
oxr-embedded-api-layer
branch
from
October 3, 2024 09:15
67663d5
to
0850691
Compare
This PR also fixes the namespacing of the asmdefs to match the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR:
1.0.25
as the best proxy for the loader version in use which can't be checked directly.It is currently a draft as it doesn't include the final version of the API layer that will ship with this option, but is ready for review.
Contributor Tasks
These tasks are for the merge request creator to tick off when creating a merge request.
breaking
to this MR.Reviewer Tasks
Add any instructions or tasks for the reviewer such as specific test considerations before this can be merged.
Use emojis in review threads to communicate intent and help contributors.
Closes JIRA Issue
If this MR closes any JIRA issues list them below in the form
Closes PROJECT-#