Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peeling algorithm and test cases #130

Merged

Conversation

stevenhwu
Copy link
Collaborator

Related to #80

  • Update peel forward methods using eigen matrix.resize().
    The default resize() is column ordered and some matrices need to add/remove transpose().
  • Unittest
    Update old unittest and avoid resize() function.
    Implemented more unittest with fixed dataset and results.
    Add another fixture to setup the family and workspace for these tests.
  • The R code used to generate and calculate are in test/script/R/generate_family_data.R

Other TODO list for #80

  • Need to update methods related to peel backwards.
  • Implement to unittests for peel backwards.

Update peel forward methods using eigen matrix.resize().
The default resize() is column ordered and some matrices need to add/remove transpose().

Implemented more unittest with fixed dataset and results.
Add another fixture to setup the family and workspace for these tests.
The R code used to generate and calculate are in test/script/R/generate_family_data.R

TODO:
 - Need to update methods related to peel backwards.
 - Implement to unittests for peel backwards.
@dng-jenkins
Copy link

Can one of the admins verify this patch?

@reedacartwright
Copy link
Contributor

Jenkins, ok to test

Reed A. Cartwright, PhD
Barrett Honors Faculty
Assistant Professor of Genomics, Evolution, and Bioinformatics
School of Life Sciences
Human and Comparative Genomics Laboratory
The Biodesign Institute

Arizona State University

Availability: http://links.asu.edu/CartwrightCalendar
Address: The Biodesign Institute, PO Box 875301, Tempe, AZ 85287-5301 USA
Packages: The Biodesign Institute, 1001 S. McAllister Ave, Tempe, AZ
85287-5301 USA
Office: Biodesign A-224A, 1-480-965-9949
Website: http://cartwrig.ht/

On Fri, Mar 25, 2016 at 5:11 PM, Jenkins Bot [email protected]
wrote:

Can one of the admins verify this patch?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#130 (comment)

@reedacartwright reedacartwright merged commit b4256ad into ultimatesource:develop Mar 26, 2016
@stevenhwu stevenhwu deleted the feature_update_peeling branch June 8, 2016 19:30
@stevenhwu stevenhwu restored the feature_update_peeling branch June 8, 2016 19:39
@stevenhwu stevenhwu deleted the feature_update_peeling branch June 8, 2016 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants