Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test peeling #80

Open
3 of 11 tasks
stevenhwu opened this issue Jan 21, 2016 · 0 comments
Open
3 of 11 tasks

Test peeling #80

stevenhwu opened this issue Jan 21, 2016 · 0 comments
Assignees
@stevenhwu
Labels
Type-RE

Comments

@stevenhwu
Copy link
Collaborator

stevenhwu commented Jan 21, 2016 •
edited
Loading

Part of #35 and #49

  • Create boost tests for peeling.cc
    • tests for forward peeling
    • tests for reverse peeling
  • Refactor peeling.cc to reduce redundancy
    • forward peeling
    • reverse peeling

TODO:

  • Maybe some functions should be in workspace_t
  • Refactor "family". All hard coded, could be parent-child OR Dad-Mom-Child...(children). Better check/test required. Relate to other part of the code (pedigree)
  • Better CMake file
  • Better way to run boost tests multiple times, maybe BOOST_DATA_TEST_CASE or BOOST_PARAM_TEST_CASE.
  • Clean up global functions/variables (namespace?)
@stevenhwu stevenhwu self-assigned this Jan 21, 2016
stevenhwu added a commit to stevenhwu/denovogear that referenced this issue Jan 21, 2016
@stevenhwu
Merge test_peeling from develop_sw.
0e4ec4f 
Linked to issue ultimatesource#80.
Test peeling.cc only.
@stevenhwu stevenhwu mentioned this issue Jan 21, 2016
Closed
stevenhwu added a commit to stevenhwu/denovogear that referenced this issue Jan 21, 2016
@stevenhwu
Merge test_peeling from develop_sw.
edfb2e5 
    Linked to issue ultimatesource#80.
    Test peeling.cc only.
This was referenced Jan 21, 2016
Merged
Closed
stevenhwu added a commit to stevenhwu/denovogear that referenced this issue Jan 25, 2016
@stevenhwu
Update peeling.cc to ensure performance.
9d6a20b 
Add test codes to compare performance.
Issues: ultimatesource#80 ultimatesource#85
PR: ultimatesource#83
stevenhwu added a commit to stevenhwu/denovogear that referenced this issue Mar 8, 2016
@stevenhwu
Update peeling.cc to ensure performance.
88393b2 
Add test codes to compare performance.
Issues: ultimatesource#80 ultimatesource#85
PR: ultimatesource#83
@stevenhwu stevenhwu mentioned this issue Mar 9, 2016
Closed
@stevenhwu stevenhwu mentioned this issue Mar 26, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenhwu stevenhwu

Labels
Type-RE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevenhwu