Feat configure plugins #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support configuring core plugins and unblocked plugins. This is done through an object which uses plugin.id as key to index. Each plugin can have a custom config in there of type object. Config can also be true or false: true will always activate the plugin and skip shouldActivateCheck, false will always disable the plugin and skip shouldActivateCheck. Implementation in hero core is almost exact same as in ulixee/unblocked#101 except some minor type differences. The options are passed in through hero constructor. Constructor now also has support to configure Unblocked plugin classes per hero session.