fix(timetravel): push dom changes one at a time

CLOSES #252
ulixee · Mar 11, 2024 · b179075 · b179075
1 parent abc4fbf
commit b179075
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/timetravel/injected-scripts/domReplayer.ts b/timetravel/injected-scripts/domReplayer.ts
@@ -94,7 +94,9 @@ class DomReplayer {
   }
 
   private applyDomChanges(changeEvents: IFrontendDomChangeEvent[], isReverse = false): void {
-    this.pendingDomChanges.push(...changeEvents);
+    for (const change of changeEvents) {
+      this.pendingDomChanges.push(change);
+    }
     if (document.readyState !== 'complete') {
       document.addEventListener('DOMContentLoaded', () => this.applyDomChanges([]), { once: true });
       return;

diff --git a/timetravel/lib/MirrorPage.ts b/timetravel/lib/MirrorPage.ts
@@ -436,7 +436,9 @@ export default class MirrorPage extends TypedEventEmitter<{
         this.domRecording.paintEvents.push(paint);
         this.paintEventByTimestamp[paint.timestamp] = paint;
       } else {
-        existing.changeEvents.push(...paint.changeEvents);
+        for (const change of paint.changeEvents) {
+          existing.changeEvents.push(change);
+        }
         existing.changeEvents.sort((a, b) => {
           if (a.frameId === b.frameId) return a.eventIndex - b.eventIndex;
           return a.frameId - b.frameId;
@@ -458,7 +460,9 @@ export default class MirrorPage extends TypedEventEmitter<{
 
   private onPageEvents(event: ITabEventParams['page-events']): void {
     const { domChanges } = event.records;
-    this.pendingDomChanges.push(...domChanges);
+    for (const record of domChanges) {
+      this.pendingDomChanges.push(record);
+    }
   }
 
   private async evaluate<T>(expression: string): Promise<T> {