Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing namespace in sys crate build script #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DanielSporysz
Copy link

@DanielSporysz DanielSporysz commented May 11, 2024

The build script of sys crate is throwing an error due to undeclared types. Let's fix it by adding namespaces.

@HoKim98
Copy link
Member

HoKim98 commented May 13, 2024

File is imported on line 177.

use std::fs::File;

Path is imported on line 4.
use std::path::Path;

So I think there is no problem building on windows. Could you check and comment on?

@DanielSporysz
Copy link
Author

@HoKim98 the build was failing, until I went to .cargo\registry\src to edit the source code with these changes. I can see the imports and it's weird I saw namespace errors, but this is what fixed my failures. 🤔

@HoKim98
Copy link
Member

HoKim98 commented May 27, 2024

That's strange. Let me check on a windows VM and comment again.

@orpos
Copy link

orpos commented Sep 24, 2024

for me it was giving the same error but when i used this pr on the cargo file it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants