Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to QA5 to prevent False positives from deleted associations #1371

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Updates to QA5 to prevent False positives from deleted associations #1371

merged 4 commits into from
Dec 30, 2024

Conversation

dougmills-DIT
Copy link
Contributor

TOPS-1874

  • Add pytest mark to all business rules for easier testing business rules in isolation
  • Add test to check deleted associations are not being incorrectly checked
  • Update QA5

Why

  • The rule incorrectly raised rule violations
  • No test checked that deleted associations were not being checked

What

  • Update QA5
  • Test to verify the rule is operating correctly

Checklist

  • Requires migrations? No
  • Requires dependency updates? No

Links to relevant material
See: Description

@dougmills-DIT dougmills-DIT requested a review from a team as a code owner December 30, 2024 12:25
@dougmills-DIT
Copy link
Contributor Author

the only file that has changed that will have an effect in the running application is quotas/business_rules.py the rest are test updates

CPrich905
CPrich905 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@CPrich905 CPrich905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dougmills-DIT dougmills-DIT merged commit b0b457e into master Dec 30, 2024
8 checks passed
@dougmills-DIT dougmills-DIT deleted the tops_1874 branch December 30, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjamc mattjamc mattjamc left review comments

@CPrich905 CPrich905 CPrich905 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougmills-DIT @CPrich905 @mattjamc