Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tp2000 1640 new ref doc data importer #1370

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Tp2000 1640 new ref doc data importer #1370

wants to merge 13 commits into from

Conversation

dougmills-DIT
Copy link
Contributor

@dougmills-DIT dougmills-DIT commented Dec 24, 2024 •
edited
Loading

TP2000-1640 Create new reference documents data importer

  • Updates to reference document alignment checks
  • Create web based data importer for reference documents using new format
  • Improve UI to display passes and failures
  • Divide up results based on year for display

Why

  • Previous import process was done via command line and was not accessible by most users
  • Some alignment checks did not operate as expected
  • Review of alignment check was was not easy to navigate

What

  • Updates to reference document alignment checks
  • Create web based data importer for reference documents using new format
  • Improve UI to display passes and failures
  • Divide up results based on year for display

Checklist

  • Requires migrations? yes
  • Requires dependency updates? no

Links to relevant material
See: ticket

@dougmills-DIT dougmills-DIT marked this pull request as ready for review December 27, 2024 09:18
@dougmills-DIT dougmills-DIT requested a review from a team as a code owner December 27, 2024 09:18
Luisella21
Luisella21 reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@Luisella21 Luisella21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, from the point of view of the code. I don't have enough experience of TAP to comment on the 'logic'.
Very minor changes/coments requested.

reference_documents/check/ref_rates.py Show resolved Hide resolved
reference_documents/models.py Show resolved Hide resolved
reference_documents/tests/test_csv_upload_forms.py Outdated Show resolved Hide resolved
reference_documents/check/base.py Outdated Show resolved Hide resolved
reference_documents/csv_importer/importer.py Outdated Show resolved Hide resolved
Luisella21
Luisella21 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@Luisella21 Luisella21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luisella21 Luisella21 Luisella21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougmills-DIT @Luisella21