Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quota definition create link fix #1190

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Quota definition create link fix #1190

merged 4 commits into from
Mar 26, 2024

Conversation

eadpearce
Copy link
Contributor

Quota definition create link fix

Why

  • User research flagged that the create link on the confirm create page for quota definitions is broken

What

  • Updates the get_url method to make sure the correct url is generated
  • Removes the try/except so it no longer fails silently
  • Adds tests

@eadpearce eadpearce requested a review from a team as a code owner March 25, 2024 11:40
@CPrich905
Copy link
Collaborator

Looks like I might have jumped the gun on approving - failing test
NoReverseMatch: Reverse for 'quota_definition-ui-detail' not found. 'quota_definition-ui-detail' is not a valid view function or pattern name.

@eadpearce eadpearce merged commit 8282896 into master Mar 26, 2024
7 checks passed
@eadpearce eadpearce deleted the quota-definition-create-link-fix branch March 26, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPrich905 CPrich905 CPrich905 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eadpearce @CPrich905