TP2000-1259 Fix field overflow error #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpepper-trade
force-pushed
the
TP2000-1259--field-overflow-error
branch
from
23d6e1a to
31b12e3
Compare
Co-authored-by: "Dale Cannon" <[email protected]>
paulpepper-trade
force-pushed
the
TP2000-1259--field-overflow-error
branch
from
31b12e3 to
e540137
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1186 +/- ##
==========================================
- Coverage 93.11% 93.11% -0.01%
==========================================
Files 582 582
Lines 44041 44041
Branches 3181 3181
==========================================
- Hits 41009 41007 -2
- Misses 2415 2416 +1
- Partials 617 618 +1 ☔ View full report in Codecov by Sentry. |
dalecannon
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP2000-1259 Fix field overflow error
Why
An attempt to apply a value of
113.900toTrackedModelCheck.processing_timedefined asDecimalField(null=True, decimal_places=4, max_digits=6)is causing a database field overflow error.Credit to @dalecannon for identifying the cause of this issue.
What
Alter
TrackedModelCheck.processing_timefrom aDecimalFieldtoFloatField.Checklist