Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tp2000 1194 js linter #1185

Merged
merged 10 commits into from
Mar 28, 2024
Merged

Tp2000 1194 js linter #1185

merged 10 commits into from
Mar 28, 2024

Conversation

a-gleeson
Copy link
Contributor

TP2000-1194 JS linter and pre commit

Why

As we hae code formating and standardisation for pyhton code we should have similar set up for Javascript code.

What

  • sets up an es lint configuration for JS, JSX and React
  • pre commit for prettier and es lint

Checklist

  • Requires dependency updates? - yes npm

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.11%. Comparing base (862d604) to head (35a1528).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1185      +/-   ##
==========================================
- Coverage   93.11%   93.11%   -0.01%     
==========================================
  Files         582      582              
  Lines       43964    44041      +77     
  Branches     3170     3181      +11     
==========================================
+ Hits        40938    41008      +70     
- Misses       2412     2416       +4     
- Partials      614      617       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-gleeson a-gleeson marked this pull request as ready for review March 25, 2024 17:04
@a-gleeson a-gleeson requested a review from a team as a code owner March 25, 2024 17:04
@a-gleeson a-gleeson merged commit 1a172dc into master Mar 28, 2024
8 checks passed
@a-gleeson a-gleeson deleted the TP2000-1194--js-linter branch March 28, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants