fix all files using pre-commit #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanosParalakis
added
the
experimental
common/business_rules.py
Outdated
| @@ -132,8 +132,8 @@ def get_linked_models( | |||
|
|
|||
| :param model TrackedModel: Get models linked to this model instance | |||
| :param transaction Transaction: Get latest approved versions of linked | |||
| models as of this transaction | |||
| :rtype Iterator[TrackedModel]: The linked models | |||
| models as of this transaction :rtype Iterator[TrackedModel]: The | |||
There was a problem hiding this comment.
Is the :rtype meant to be on a new line, in keeping with the :param lines?
common/business_rules.py
Outdated
| @@ -226,8 +228,8 @@ def skip_when_update_type(cls: Type[BusinessRule], update_types: Iterable[Update | |||
| """ | |||
| Skip business rule validation for given update types. | |||
|
|
|||
| :param cls Type[BusinessRule]: The BusinessRule to decorate | |||
| :param update_types Iterable[int]: The UpdateTypes to skip | |||
| :param cls Type[BusinessRule]: The BusinessRule to decorate :param | |||
There was a problem hiding this comment.
Should there be a line break before the second :param?
PanosParalakis
force-pushed
the
experimental/pre-commit-code-formatting
branch
from
8bb6763 to
7835b39
Compare
common/business_rules.py
Outdated
| @@ -226,8 +229,10 @@ def skip_when_update_type(cls: Type[BusinessRule], update_types: Iterable[Update | |||
| """ | |||
| Skip business rule validation for given update types. | |||
|
|
|||
| :param cls Type[BusinessRule]: The BusinessRule to decorate | |||
| :param update_types Iterable[int]: The UpdateTypes to skip | |||
| :param cls: The BusinessRule to decorate :param | |||
There was a problem hiding this comment.
Is that second :param on this line a stray one?
There was a problem hiding this comment.
Sorry no I have already pushed a fix for it :)
dalecannon
reviewed
Mar 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1170 +/- ##
==========================================
- Coverage 93.11% 93.11% -0.01%
==========================================
Files 580 580
Lines 43649 43646 -3
Branches 3139 3139
==========================================
- Hits 40645 40641 -4
- Misses 2393 2394 +1
Partials 611 611 ☔ View full report in Codecov by Sentry. |
dalecannon
reviewed
Mar 5, 2024
dalecannon
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all files using pre-commit
Why
It looks like some files have not been checked using pre-commit hooks at the past. By manually running pre-commit against all errors found are resolved
What