Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1193 Upgrade to Django 4.2 #1163

Merged
merged 42 commits into from
Feb 28, 2024
Merged

Conversation

dalecannon
Copy link
Contributor

@dalecannon dalecannon commented Feb 23, 2024

TP2000-1193 Upgrade to Django 4.2 (LTS)

Why

Our current version of Django, 3.2 (LTS), will no longer be supported from 30th April 2024.

What

  • Upgrades package versions

    • Bumps Django to 4.2.10 (LTS)
    • Bumps other dependencies
  • Changes deprecated settings and features

    • Removes SECURE_BROWSER_XSS_FITLER deprecated setting [1]
    • Replaces pytz module with recommended 'zoneinfo` module [2]
    • Replaces logout GET request with a POST request [3]
    • Replace STATICFILES_STORAGE setting with new STORAGES setting [4]
  • Resolves errors resulting from version upgrades

    • RemovesFormMixin from WorkBasketDeleteView now that DeleteView includes it [5]
    • Add path to BundleTracker() in webpack.config.js [6]
    • Uses django-webpack-loader's jinja2 extension wrapper for render_bundle() following the introduction of an incompatible parameter [7]
    • Add renderer attribute to common/forms.py/FormSet() [8]
    • Prevents ValueErrors when calling related managers for unsaved instances that previously would have returned as empty querysets [9]

Checklist

  • Requires dependency updates? Yes

@dalecannon dalecannon force-pushed the TP2000-1193--upgrade-to-django-4-2 branch from 19cde7d to c45b05f Compare February 23, 2024 14:46
@dalecannon dalecannon force-pushed the TP2000-1193--upgrade-to-django-4-2 branch from c45b05f to 83dba31 Compare February 23, 2024 14:48
@dalecannon dalecannon force-pushed the TP2000-1193--upgrade-to-django-4-2 branch from c9ab810 to d879395 Compare February 27, 2024 10:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.12%. Comparing base (ab0e4ca) to head (d879395).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1163   +/-   ##
=======================================
  Coverage   93.11%   93.12%           
=======================================
  Files         580      580           
  Lines       43650    43651    +1     
  Branches     3141     3140    -1     
=======================================
+ Hits        40645    40648    +3     
  Misses       2393     2393           
+ Partials      612      610    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalecannon dalecannon marked this pull request as ready for review February 27, 2024 12:00
@PanosParalakis PanosParalakis added the dependencies Pull requests that update a dependency file label Feb 28, 2024
@dalecannon dalecannon requested a review from a team February 28, 2024 11:03
common/forms.py Outdated Show resolved Hide resolved
common/models/trackedmodel.py Show resolved Hide resolved
quotas/forms.py Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
@dalecannon dalecannon merged commit ad0ff0c into master Feb 28, 2024
4 checks passed
@dalecannon dalecannon deleted the TP2000-1193--upgrade-to-django-4-2 branch February 28, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants