Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DBTP-1644: handle next token when getting services for application #721

Merged

Conversation

james-francis-MT
Copy link
Contributor

@james-francis-MT james-francis-MT commented Jan 13, 2025

Addresses DBTP-1644


Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
    - If the work includes user interface changes, before and after screenshots included in description
    - Includes any applicable changes to the documentation in this code base
    - Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

  • Run the end to end tests for this branch and confirm that they are passing

@james-francis-MT james-francis-MT requested a review from a team as a code owner January 13, 2025 16:23
@james-francis-MT james-francis-MT force-pushed the increase-number-of-results-get-parameters-by-path-grabs branch from 2eff857 to 4689235 Compare January 13, 2025 16:27
@james-francis-MT james-francis-MT force-pushed the increase-number-of-results-get-parameters-by-path-grabs branch from 4689235 to e2e51a8 Compare January 13, 2025 16:27
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
640 4 636 3
View the top 3 failed tests by shortest run time
tests/platform_helper/utils/test_application.py::ApplicationTest::test_load_application_does_not_fail_when_addons_params_are_present
Stack Traces | 0.005s run time
.../platform_helper/utils/test_application.py:169: in test_load_application_does_not_fail_when_addons_params_are_present
    application = load_application(default_session=mock_session)
E   TypeError: load_application() missing 1 required positional argument: 'app'
tests/platform_helper/utils/test_application.py::ApplicationTest::test_loading_an_empty_application
Stack Traces | 0.166s run time
.../platform_helper/utils/test_application.py:191: in test_loading_an_empty_application
    application = load_application()
E   TypeError: load_application() missing 2 required positional arguments: 'app' and 'default_session'
tests/platform_helper/utils/test_application.py::ApplicationTest::test_loading_an_application_with_environments
Stack Traces | 0.549s run time
.../platform_helper/utils/test_application.py:114: in test_loading_an_application_with_environments
    application = load_application()
E   TypeError: load_application() missing 2 required positional arguments: 'app' and 'default_session'

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@james-francis-MT james-francis-MT force-pushed the increase-number-of-results-get-parameters-by-path-grabs branch from 111e43d to 4c7880e Compare January 13, 2025 16:38
@james-francis-MT james-francis-MT force-pushed the increase-number-of-results-get-parameters-by-path-grabs branch from 903d8bd to 6a505f9 Compare January 13, 2025 16:41
@james-francis-MT james-francis-MT merged commit b87e532 into main Jan 13, 2025
10 checks passed
@james-francis-MT james-francis-MT deleted the increase-number-of-results-get-parameters-by-path-grabs branch January 13, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants