Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Inject io into maintenance page domain #720

Open
wants to merge 1 commit into
base: DBTP-1630-terraform-environment-tests
Choose a base branch
from

Conversation

ksugden
Copy link
Contributor

@ksugden ksugden commented Jan 13, 2025

Addresses DBTP-


Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • If the work includes user interface changes, before and after screenshots included in description
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

  • Run the end to end tests for this branch and confirm that they are passing

@ksugden ksugden changed the base branch from main to DBTP-1630-terraform-environment-tests January 13, 2025 13:46
@ksugden ksugden force-pushed the inject-io-into-maintenance-page-domain branch from b8ef22e to 22cbc52 Compare January 13, 2025 14:00
@chiaramapellimt chiaramapellimt changed the title Inject io into maintenance page domain refactor: Inject io into maintenance page domain Jan 13, 2025
@chiaramapellimt chiaramapellimt marked this pull request as ready for review January 13, 2025 15:27
@chiaramapellimt chiaramapellimt requested a review from a team as a code owner January 13, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant