-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: DBTP-1630 - copilot environment domain tests #716
Draft
ksugden
wants to merge
7
commits into
DBTP-1630-terraform-environment-tests
Choose a base branch
from
DBTP-1630-copilot-environment-tests
base: DBTP-1630-terraform-environment-tests
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor: DBTP-1630 - copilot environment domain tests #716
ksugden
wants to merge
7
commits into
DBTP-1630-terraform-environment-tests
from
DBTP-1630-copilot-environment-tests
+307
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksugden
changed the base branch from
DBTP-1630-rehome-legacy-tests
to
DBTP-1630-terraform-environment-tests
January 13, 2025 09:24
@@ -41,6 +41,8 @@ def test_raises_a_platform_exception_if_environment_does_not_exist_in_config(sel | |||
): | |||
terraform_environment.generate("not-an-environment") | |||
|
|||
# TODO test can be made more complete by using a file fixture for the expected content on the manifest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we agree that asserting on the mock of write was sufficient for this?
ksugden
changed the title
Dbtp 1630 copilot environment tests
refactor: DBTP-1630 - copilot environment domain tests
Jan 13, 2025
…pilotTemplating and CopilotEnvironment
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DBTP-
Checklist:
Title:
Description:
Tasks: