Ltd 4637 add aria labelledby to ecju textarea

[stuaxo]

Add aria-labelledby to the reason for closing textarea, this references the hint widget.

Added a unit test to verify this, as well as the existing aria-describedby attribute.

[kevincarrogan]

This doesn't seem like the right fix to the problem to me personally.

If we are pointing at this element and calling it a label then it probably should just be the label.

Alternatively I think we could use aria-label but it seems very strange to have an element be both the aria label and description, which suggests to me we're getting something else wrong.

[stuaxo]

I need to check out the ARIA docs.

Was hoping for some of the feedback re:description vs label. The description, we get for free.

If we are pointing at this element and calling it a label then it probably should just be the label.

To clarify - to get here would removing the aria-describedby be enough ? It looks like there used to be a preference for labelledby vs label, but that was a while ago, e.g. https://stackoverflow.com/a/19616909 - then again I don't know how often people update their screenreaders.

[stuaxo]

Wrote that + realised you probably meant using the field label ?

[stuaxo]

In this case it looks like the label of the field is deliberately blank, so it might make sense using labelledby and removing the describedby.

[stuaxo]

I wonder if having the <label> but making it not visible would be screenreader friendly.

[kevincarrogan]

What I'm saying though is, why isn't the help text just the label? We're literally saying it's a label via the aria element so why not just make it the label?

[hnryjmes]

test coverage looks good. also I'm pretty sure that this solves the issue, as the help text is now associated with the textarea when looking using the Chrome DevTools Accessibility tool, and it wasn't before

[stuaxo]

@kevincarrogan making the help text a label, is the most straightforward thing. The default styling for labels, is to have black text + slightly different spacing, can we live with that or should we change the style.

On the side of living with it: these styles come from the govuk design system, we should leave them.

On the side of changing it to grey and changing the spacing: We aren't changing the design (though makes me wonder if the users would care) - might see what Colin thinks.

[codecov]

Codecov upload limit reached ⚠️

This org is currently on the free Basic Plan; which includes 250 free private repo uploads each rolling month. This limit has been reached and additional reports cannot be generated. For unlimited uploads, upgrade to our pro plan.

Do you have questions or need help? Connect with our sales team today at [email protected]