Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.md #56

Merged
merged 32 commits into from
Jun 3, 2024
Merged

Update index.md #56

merged 32 commits into from
Jun 3, 2024

Conversation

Davsarper
Copy link
Contributor

No description provided.

@Davsarper Davsarper marked this pull request as ready for review May 29, 2024 15:12
Davsarper
Davsarper commented May 29, 2024
View reviewed changes
docs/structure/citizen-agency.md Outdated Show resolved Hide resolved
docs/structure/citizen-agency.md Outdated Show resolved Hide resolved
@Davsarper
Copy link
Contributor Author

Had to take Dropbox links out as it was not building, currently trying to figure out why Lint fails. Don't understand it

Davsarper
Davsarper commented May 30, 2024
View reviewed changes
Copy link
Contributor Author

@Davsarper Davsarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest all lint modification, I am sure manually doing this was dumb and there has to be a way for lint to just apply its own suggestions but...

docs/structure/citizen-agency.md Outdated Show resolved Hide resolved
docs/structure/citizen-agency.md Outdated Show resolved Hide resolved
docs/structure/citizen-agency.md Outdated Show resolved Hide resolved
docs/structure/citizen-agency.md Outdated Show resolved Hide resolved
docs/structure/citizen-agency.md Outdated Show resolved Hide resolved
docs/structure/satre.md Outdated Show resolved Hide resolved
docs/structure/satre.md Outdated Show resolved Hide resolved
docs/structure/sde-tre-terminology.md Outdated Show resolved Hide resolved
docs/structure/sde-tre-terminology.md Outdated Show resolved Hide resolved
docs/structure/tre-glossary.md Show resolved Hide resolved
@Davsarper
Apply suggestions from code review
6cb00d1 
commit suggestions from my dumb lint review
Davsarper
Davsarper commented May 30, 2024
View reviewed changes
Copy link
Contributor Author

@Davsarper Davsarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of white spaces from lint

docs/structure/citizen-agency.md Outdated Show resolved Hide resolved
docs/structure/citizen-agency.md Outdated Show resolved Hide resolved
docs/structure/citizen-agency.md Outdated Show resolved Hide resolved
docs/structure/citizen-agency.md Outdated Show resolved Hide resolved
docs/structure/citizen-agency.md Outdated Show resolved Hide resolved
docs/structure/sde-tre-terminology.md Outdated Show resolved Hide resolved
docs/structure/tre-glossary.md Show resolved Hide resolved
docs/structure/tre-glossary.md Outdated Show resolved Hide resolved
docs/structure/tre-glossary.md Outdated Show resolved Hide resolved
docs/structure/tre-glossary.md Show resolved Hide resolved
Davsarper
Davsarper commented May 30, 2024
View reviewed changes
Copy link
Contributor Author

@Davsarper Davsarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more spacing, having issue to add a second level to lists so worked around that. Is there a different syntax than ' -'?

docs/structure/citizen-agency.md Outdated Show resolved Hide resolved
docs/structure/cybersecurity-risk.md Outdated Show resolved Hide resolved
docs/structure/extending-control.md Outdated Show resolved Hide resolved
docs/structure/extending-control.md Outdated Show resolved Hide resolved
docs/structure/funding-sustainability.md Outdated Show resolved Hide resolved
docs/structure/satre.md Outdated Show resolved Hide resolved
docs/structure/tre-glossary.md Outdated Show resolved Hide resolved
Davsarper
Davsarper commented May 30, 2024
View reviewed changes
Copy link
Contributor Author

@Davsarper Davsarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last two lint changes?

docs/structure/cybersecurity-risk.md Show resolved Hide resolved
docs/structure/funding-sustainability.md Show resolved Hide resolved
@Davsarper Davsarper self-assigned this May 30, 2024
@Davsarper Davsarper requested review from JimMadge, hardakerm and a team May 30, 2024 12:16
@JimMadge
Copy link

Isn't this the old website? 👀

@Davsarper
Copy link
Contributor Author

It is the "old" website @JimMadge ! but given migration has not happened and that the URL uktre.org still takes you here we thought worth it updating, it was supposed to be low effort (which it was content wise)

@Davsarper Davsarper requested a review from manics June 3, 2024 08:59
@manics manics merged commit 0e73f9f into main Jun 3, 2024
5 checks passed
@manics manics deleted the Davsarper-update-wg-oldweb branch June 3, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manics manics manics approved these changes

@JimMadge JimMadge Awaiting requested review from JimMadge

@hardakerm hardakerm Awaiting requested review from hardakerm

Assignees

@Davsarper Davsarper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Davsarper @JimMadge @manics