This repository has been archived by the owner on Mar 21, 2019. It is now read-only.
API: allow specifying page size #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the page size of list responses to be specified. This is to allow the case where one doesn't really care about the resources but one wants the count. In this case, one can just set page_size to 1. DRF diasallows setting page_size to 0.
Some maximum needs to be set for the page sizes which can be returned. Set 300 as an arbitrary maximum.
msb
approved these changes
Oct 15, 2018
msb
approved these changes
Oct 15, 2018
|
tested on https://test.media.cam.ac.uk for various page sizes with /media, /playlists, & /channels |
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
+ Coverage 91.28% 91.29% +<.01%
==========================================
Files 43 43
Lines 1882 1884 +2
==========================================
+ Hits 1718 1720 +2
Misses 164 164
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks out the page size changes from #358 since they are usable on their own. We also configure a maximum page size of (arbitrarily) 300 items.