Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more cleanup of obsolete deps #779

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix: more cleanup of obsolete deps #779

merged 1 commit into from
Jul 31, 2023

Conversation

petermuessig
Copy link
Member

No description provided.

@flovogt
Copy link
Member

flovogt commented Jul 31, 2023

LGTM but there might be lock file issues

@petermuessig
Copy link
Member Author

The only packages still using dependencies to the @ui5/fs are the tooling extensions for less. They also make use of the fsInterface. Not sure yet, what to do with them...

Cc: @RandomByte @matz3

@petermuessig petermuessig merged commit 221a843 into main Jul 31, 2023
5 checks passed
@petermuessig petermuessig deleted the fix/removeObsolteDeps branch July 31, 2023 11:04
flovogt
flovogt reviewed Jul 31, 2023
View reviewed changes
Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flovogt flovogt flovogt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petermuessig @flovogt