ui5-community · petermuessig · Oct 10, 2024 · Oct 10, 2024
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,6 @@
+# Private folders
+_
+
 # Ignore Mac files
 .DS_Store
 

diff --git a/packages/ui5-middleware-approuter/test/auth/ui5-auth-in-yaml.yaml b/packages/ui5-middleware-approuter/test/auth/ui5-auth-in-yaml.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-middleware-approuter/test/auth/ui5-with-localDir.yaml b/packages/ui5-middleware-approuter/test/auth/ui5-with-localDir.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-middleware-approuter/test/crud/ui5.yaml b/packages/ui5-middleware-approuter/test/crud/ui5.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-middleware-approuter/test/dest-in-env/ui5.yaml b/packages/ui5-middleware-approuter/test/dest-in-env/ui5.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-middleware-approuter/test/multitenant/ui5-auth-multitenant.yaml b/packages/ui5-middleware-approuter/test/multitenant/ui5-auth-multitenant.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-middleware-approuter/test/no-auth/ui5-no-auth-in-yaml.yaml b/packages/ui5-middleware-approuter/test/no-auth/ui5-no-auth-in-yaml.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-middleware-approuter/test/no-auth/ui5.yaml b/packages/ui5-middleware-approuter/test/no-auth/ui5.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-middleware-approuter/test/options/ui5-no-config.yaml b/packages/ui5-middleware-approuter/test/options/ui5-no-config.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-middleware-approuter/test/options/ui5-some-config.yaml b/packages/ui5-middleware-approuter/test/options/ui5-some-config.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-middleware-approuter/test/rewrite/ui5-rewrite-disabled.yaml b/packages/ui5-middleware-approuter/test/rewrite/ui5-rewrite-disabled.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-middleware-approuter/test/rewrite/ui5-rewrite-partial.yaml b/packages/ui5-middleware-approuter/test/rewrite/ui5-rewrite-partial.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-middleware-approuter/test/rewrite/ui5.yaml b/packages/ui5-middleware-approuter/test/rewrite/ui5.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-middleware-onelogin/sample/example_embeddedflp/ui5.yaml b/packages/ui5-middleware-onelogin/sample/example_embeddedflp/ui5.yaml
@@ -9,7 +9,7 @@ resources:
 
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-middleware-onelogin/sample/example_simpleproxy_and_onelogin/ui5.yaml b/packages/ui5-middleware-onelogin/sample/example_simpleproxy_and_onelogin/ui5.yaml
@@ -9,7 +9,7 @@ resources:
 
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-cachebuster/test/__assets__/ui5.basic.yaml b/packages/ui5-task-cachebuster/test/__assets__/ui5.basic.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-cachebuster/test/__assets__/ui5.noExcluded.yaml b/packages/ui5-task-cachebuster/test/__assets__/ui5.noExcluded.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-cachebuster/test/__assets__/ui5.onlyIndex.yaml b/packages/ui5-task-cachebuster/test/__assets__/ui5.onlyIndex.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-cachebuster/test/__assets__/ui5.onlyMove.yaml b/packages/ui5-task-cachebuster/test/__assets__/ui5.onlyMove.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-copyright/test/__assets__/ui5.file-alt.yaml b/packages/ui5-task-copyright/test/__assets__/ui5.file-alt.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-copyright/test/__assets__/ui5.file-env.yaml b/packages/ui5-task-copyright/test/__assets__/ui5.file-env.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-copyright/test/__assets__/ui5.file.yaml b/packages/ui5-task-copyright/test/__assets__/ui5.file.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-copyright/test/__assets__/ui5.inline-altyear.yaml b/packages/ui5-task-copyright/test/__assets__/ui5.inline-altyear.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-copyright/test/__assets__/ui5.inline.yaml b/packages/ui5-task-copyright/test/__assets__/ui5.inline.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-copyright/test/__assets__/ui5.no.copyright.yaml b/packages/ui5-task-copyright/test/__assets__/ui5.no.copyright.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app-simple/ui5.includeShims.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app-simple/ui5.includeShims.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app-simple/ui5.includeSomeDeps.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app-simple/ui5.includeSomeDeps.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.additionalFiles.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.additionalFiles.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.additionalFilesMap.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.additionalFilesMap.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.basic.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.basic.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.customZipName.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.customZipName.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.includeDeps.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.includeDeps.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.includeSomeDeps.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.includeSomeDeps.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.onlyZip.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.onlyZip.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.relativePaths.yaml b/packages/ui5-task-zipper/test/__assets__/ui5-app/ui5.relativePaths.yaml
@@ -4,7 +4,7 @@ metadata:
 type: application
 framework:
  name: OpenUI5
- version: "1.127.0"
+ version: "1.129.0"
  libraries:
  - name: sap.m
  - name: sap.ui.core

diff --git a/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents-base.js b/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents-base.js
@@ -1,44 +1,4 @@
-sap.ui.define(['sap/base/strings/hyphenate', 'sap/ui/core/webc/WebComponentRenderer', 'sap/ui/base/DataType'], (function (hyphenate, WebComponentRenderer, DataType) { 'use strict';
-
- // Fixed with https://github.com/SAP/openui5/commit/7a4615e3fe55221ae9de9d876d3eed209f71a5b1 in UI5 1.128.0
-
-
- WebComponentRenderer.renderAttributeProperties = function (oRm, oWebComponent) {
- var oAttrProperties = oWebComponent.getMetadata().getPropertiesByMapping("property");
- // ##### MODIFICATION START #####
- var aPropsToAlwaysSet = ["enabled"].concat(
- Object.entries(oWebComponent.getMetadata().getPropertyDefaults()).map(([key, value]) => {
- return value !== undefined && value !== false ? key : null;
- })
- ); // some properties can be initial and still have a non-default value due to side effects (e.g. EnabledPropagator)
- // ##### MODIFICATION END #####
- for (var sPropName in oAttrProperties) {
- if (oWebComponent.isPropertyInitial(sPropName) && !aPropsToAlwaysSet.includes(sPropName)) {
- continue; // do not set attributes for properties that were not explicitly set or bound
- }
-
- var oPropData = oAttrProperties[sPropName];
- var vPropValue = oPropData.get(oWebComponent);
- if (oPropData.type === "object" || typeof vPropValue === "object") {
- continue; // Properties of type "object" and custom-type properties with object values are set during onAfterRendering
- }
-
- var sAttrName = oPropData._sMapTo ? oPropData._sMapTo : hyphenate(sPropName);
- if (oPropData._fnMappingFormatter) {
- vPropValue = oWebComponent[oPropData._fnMappingFormatter].call(oWebComponent, vPropValue);
- }
-
- if (oPropData.type === "boolean") {
- if (vPropValue) {
- oRm.attr(sAttrName, "");
- }
- } else {
- if (vPropValue != null) {
- oRm.attr(sAttrName, vPropValue);
- }
- }
- }
- };
+sap.ui.define(['sap/ui/base/DataType'], (function (DataType) { 'use strict';
 
  const pkg = {
  "_ui5metadata": {

diff --git a/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents.js b/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents.js
@@ -1,4 +1,4 @@
-sap.ui.define(['sap/ui/base/DataType', './webcomponents-base', 'sap/base/strings/hyphenate', 'sap/ui/core/webc/WebComponentRenderer'], (function (DataType, _ui5_webcomponentsBase, hyphenate, WebComponentRenderer) { 'use strict';
+sap.ui.define(['sap/ui/base/DataType', './webcomponents-base'], (function (DataType, _ui5_webcomponentsBase) { 'use strict';
 
  const pkg = {
  "_ui5metadata": {

diff --git a/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents/dist/CheckBox.js b/packages/ui5-tooling-modules/test/__snap__/4370bd2f/@ui5/webcomponents/dist/CheckBox.js
@@ -1,4 +1,4 @@
-sap.ui.define(['ui5/ecosystem/demo/app/resources/@ui5/webcomponents', 'sap/ui/core/webc/WebComponent', 'sap/ui/base/DataType', 'ui5/ecosystem/demo/app/resources/@ui5/webcomponents-base', 'sap/base/strings/hyphenate', 'sap/ui/core/webc/WebComponentRenderer'], (function (_ui5_webcomponents, WebComponentBaseClass, DataType, _ui5_webcomponentsBase, hyphenate, WebComponentRenderer) { 'use strict';
+sap.ui.define(['ui5/ecosystem/demo/app/resources/@ui5/webcomponents', 'sap/ui/core/webc/WebComponent', 'sap/ui/base/DataType', 'ui5/ecosystem/demo/app/resources/@ui5/webcomponents-base'], (function (_ui5_webcomponents, WebComponentBaseClass, DataType, _ui5_webcomponentsBase) { 'use strict';
 
  const isSSR$2 = typeof document === "undefined";
  const internals = {

diff --git a/packages/ui5-tooling-modules/test/__snap__/d726ec84/@ui5/webcomponents.js b/packages/ui5-tooling-modules/test/__snap__/d726ec84/@ui5/webcomponents.js
@@ -1,4 +1,4 @@
-sap.ui.define(['sap/ui/base/DataType', '../webcomponents-base', 'sap/base/strings/hyphenate', 'sap/ui/core/webc/WebComponentRenderer'], (function (DataType, _ui5_webcomponentsBase, hyphenate, WebComponentRenderer) { 'use strict';
+sap.ui.define(['sap/ui/base/DataType', '../webcomponents-base'], (function (DataType, _ui5_webcomponentsBase) { 'use strict';
 
  const pkg = {
  "_ui5metadata": {

diff --git a/packages/ui5-tooling-modules/test/__snap__/d726ec84/@ui5/webcomponents/dist/Panel.js b/packages/ui5-tooling-modules/test/__snap__/d726ec84/@ui5/webcomponents/dist/Panel.js
@@ -1,4 +1,4 @@
-sap.ui.define(['ui5/ecosystem/demo/app/resources/webcomponents-base', 'ui5/ecosystem/demo/app/resources/@ui5/webcomponents', 'sap/ui/core/webc/WebComponent', 'sap/base/strings/hyphenate', 'sap/ui/core/webc/WebComponentRenderer', 'sap/ui/base/DataType'], (function (_ui5_webcomponentsBase, _ui5_webcomponents, WebComponentBaseClass, hyphenate, WebComponentRenderer, DataType) { 'use strict';
+sap.ui.define(['ui5/ecosystem/demo/app/resources/webcomponents-base', 'ui5/ecosystem/demo/app/resources/@ui5/webcomponents', 'sap/ui/core/webc/WebComponent', 'sap/ui/base/DataType'], (function (_ui5_webcomponentsBase, _ui5_webcomponents, WebComponentBaseClass, DataType) { 'use strict';
 
  const kebabToCamelMap = new Map();
  const camelToKebabMap = new Map();