Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.6.2) - EPW processing: Replace opyplus module by epw #450

Merged
merged 8 commits into from
Sep 27, 2024

Conversation

AlejandroCN7
Copy link
Member

Description

This update replaces the functionality provided by the opyplus library with the new library called epw.

Opyplus includes a lot more features beyond the processing of EPW files for climate data. Sinergym stopped using these additional features a while ago. Moreover, opyplus has issues with warning messages in the latest versions of pandas.

Therefore, we opted for a more minimalist and focused installation, precisely tailored to what Sinergym needs, using the epw library.

It has been verified that variable changes are effective with the new library, ensuring that the tool functions exactly the same. Additionally, the documentation has been updated to include a list of energy variable names accessible through this library, as these names differ from those in opyplus.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Poetry: opyplus dependency replaced by epw module.
  • Common: deleted commented opyplus import and function.
  • Modeling: Replace opyplus functionality by epw module.
  • Update environemts configuration weather variable names (in mock test too).
  • Fix tests and documentation update with new epw variable names.

@AlejandroCN7 AlejandroCN7 merged commit fe45bbc into main Sep 27, 2024
6 checks passed
@AlejandroCN7 AlejandroCN7 deleted the feat/v3.6.2 branch September 27, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant