-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(v3.0.6) - Sinergym Callbacks fix in SB3 evaluation and logs #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncy and uniform for all algorithms
…v column names too
… SB3 Algorithm callbacks
…t required since version 3.0.5
…en getting attributes
AlejandroCN7
added
enhancement
New feature or request
callback
Sinergym callbacks
log
New information that should be recordered
labels
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
callback
Sinergym callbacks
enhancement
New feature or request
log
New information that should be recordered
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This minor update try to improve the Sinergym callbacks for SB3 evaluations and logs. Logging is now more flexible and uniform. Sinergym was sensitive to the class of SB3 algorithm used for the record of the metrics. With this patch, Sinergym can fix the dump frequency of the data and not depend on the algorithm type (On or Off Policy basically).
Motivation and Context
Why is this change required? What problem does it solve? Please, reference issue or issues opened previously.
Types of changes
Checklist:
autopep8
second level aggressive.isort
.cd docs && make spelling && make html
pass (required if documentation has been updated.)pytest tests/ -vv
pass. (required).pytype -d import-error sinergym/
pass. (required)Changelog:
LoggerCallback
, new argument calleddump_frequency
added, and it is uniform for all algorithms.experiment_path
toworkspace_path
.