Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fourth reconciliation PR from production/RRFS.v1 + Add PIO switch to WW3 to avoid build errors #2512 #2483

Merged

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Oct 29, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR bring the changes from #2170 into the develop branch and is work from @haiqinli.

-- Update the MYNN PBL, Smoke and subgrid cloud fraction for the RRFS.v1 code freeze.
-- Merge the bugfix in the HAILCAST diagnostic code (unit issue)

This PR also combines changes from #2512

Commit Message:

* UFSWM - MYNN PBL, Smoke and subgrid cloud fraction.
  * FV3 - MYNN PBL, Smoke and subgrid cloud fraction.
    * ccpp-physics - MYNN PBL, Smoke and subgrid cloud fraction.
    * atmos_cubed_sphere - hail diagnostics, and average of smoke/dust.
  * WW3 -  Updated to add PIO switch to avoid build error 

Priority:

  • High: Needed for SRW App

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@grantfirl
Copy link
Collaborator Author

Note: As discussed with @masih-e @danrosen25 @pedro-jm, this PR, together with changes in #2481 fixes a problem in the new fire behavior regression test (cpld_regional_atm_fbh) whereby the values of kinematic_surface_upward_sensible_heat_flux_of_fire, surface_upward_specific_humidity_flux_of_fire, and smoke_emission_of_fire are not correctly being transferred from the fire behavior module to the CCPP physics because of an error in CCPP metadata.

@grantfirl grantfirl marked this pull request as ready for review November 13, 2024 16:01
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Dec 3, 2024

@grantfirl can you sync up the branches? We can start working on this pr. #2512 (hotfix for PIO WW3 build issue and no impact on baselines) can be combined into this pr. Just need to point to https://github.com/JessicaMeixner-NOAA/WW3/tree/bug/addPIOswitch

@grantfirl
Copy link
Collaborator Author

@grantfirl can you sync up the branches? We can start working on this pr. #2512 (hotfix for PIO WW3 build issue and no impact on baselines) can be combined into this pr. Just need to point to https://github.com/JessicaMeixner-NOAA/WW3/tree/bug/addPIOswitch

Finished syncing and combining #2512.

@jkbk2004 jkbk2004 added Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Dec 4, 2024
@jkbk2004 jkbk2004 changed the title Fourth reconciliation PR from production/RRFS.v1 Fourth reconciliation PR from production/RRFS.v1 + Add PIO switch to WW3 to avoid build errors #2512 Dec 4, 2024
@MatthewMasarik-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA NOAA-EMC/WW3/pull/1324 has been merged.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Dec 6, 2024

@grantfirl the fv3 pr was merged: new hash NOAA-EMC/fv3atm@1648e17

Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WW3 commit hash looks good. Thank you @grantfirl and @jkbk2004 for including the WW3 fix in this PR!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants