Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cpld sfs rt + Pull in units updates from FV3 #2467 #2475

Merged
merged 14 commits into from
Nov 5, 2024

Conversation

dpsarmie
Copy link
Collaborator

@dpsarmie dpsarmie commented Oct 18, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR updates certain variable values in the cpld_control_sfs test. These updated variables represent the most up-to-date version that is being run by Global Workflow.

Commit Message:

* UFSWM - Updates cpld_control_sfs to use the most up-to-date configuration specs
* UFSWM - Update units attributes in netCDF output to be machine-readable
  * FV3 - Update units attributes in netCDF output to be machine-readable
    * atmos_cubed_sphere - Update units attributes in netCDF output to be machine-readable

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • cpld_control_sfs baseline changes

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

dpsarmie added a commit to dpsarmie/ufs-weather-model that referenced this pull request Oct 18, 2024
Remove changes that have been moved to ufs-community#2475
@jkbk2004
Copy link
Collaborator

@dpsarmie can you sync up branch? Also, we want to combine in #2467. just need to point to https://github.com/DWesl/fv3atm/tree/sty-unit-consistency.

@jkbk2004 jkbk2004 added Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Nov 1, 2024
@jkbk2004 jkbk2004 changed the title Fix/cpld sfs rt Fix/cpld sfs rt + Pull in units updates from FV3 #2467 Nov 4, 2024
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 4, 2024

W can start merging process.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 4, 2024

@dpsarmie new fv3 hash is NOAA-EMC/fv3atm@bd785e5

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 4, 2024

@BrianCurtis-NOAA We need to re-create baselines. it looks like the feature branch pointer was messed up. I only see cosmetic unit issue like

23c23
<               pfull:units = "mb" ;
---
>               pfull:units = "mbar" ;
28c28
<               phalf:units = "mb" ;
---
>               phalf:units = "mbar" ;
423c423
<               lhtfl_ave:units = "w/m**2" ;
---
>               lhtfl_ave:units = "W/m**2" ;

@BrianCurtis-NOAA
Copy link
Collaborator

I won't be able to complete WCOSS2 for at least this week. Maintenance.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 5, 2024

Baselines were restored across RDHPCS w/o problems.

@jkbk2004 jkbk2004 merged commit f9c91d3 into ufs-community:develop Nov 5, 2024
4 checks passed
@jkbk2004 jkbk2004 mentioned this pull request Nov 5, 2024
14 tasks
tsga added a commit to tsga/ufs-weather-model that referenced this pull request Nov 13, 2024
* develop:
  Add developmental test cases: idealized baroclinic wave and 2020 July CAPE cases + ufs-community#2459 (ufs-community#2461)
  Enable some of the intel llvm tests in rt conf + Second reconciliation PR from production/RRFS.v1 ufs-community#2481 (ufs-community#2458)
  Fix/cpld sfs rt + Pull in units updates from FV3 ufs-community#2467 (ufs-community#2475)
@dpsarmie dpsarmie deleted the fix/cpld_sfs_RT branch November 21, 2024 14:30
LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/ufs-weather-model that referenced this pull request Dec 5, 2024
…fs-community#2475)

* UFSWM - Updates cpld_control_sfs to use the most up-to-date configuration specs
* UFSWM - Update units attributes in netCDF output to be machine-readable
  * FV3 - Update units attributes in netCDF output to be machine-readable
    * atmos_cubed_sphere - Update units attributes in netCDF output to be machine-readable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cpld_control_sfs test needs updated parameter values
4 participants