Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix to update with cubed sphere bug fix #2362

Merged
merged 46 commits into from
Jul 16, 2024
Merged

Hotfix to update with cubed sphere bug fix #2362

merged 46 commits into from
Jul 16, 2024

Conversation

jkbk2004
Copy link
Collaborator

@jkbk2004 jkbk2004 commented Jul 11, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Random crash for the following regional cases: a floating-point exception in subroutine a2b_ord2 in FV3/atmos_cubed_sphere/model/a2b_edge.F90

  • conus13km_debug_intel
  • conus13km_debug_2threads_intel
  • hafs_regional_storm_following_1nest_atm_ocn_debug_intel

Commit Message:

* UFSWM - 
  * FV3 - 
    * ccpp-physics - 
    * atmos_cubed_sphere - bug fix to address debug mode crashes caused by floating-point exception in subroutine a2b_ord2 in model/a2b_edge.F90

Priority:

  • Critical Bugfix: Reason

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

jkbk2004 added 30 commits March 24, 2024 17:15
@jkbk2004 jkbk2004 changed the title Hotfix to update cubed sphere hash Hotfix to update with cubed sphere bug fix Jul 12, 2024
@jkbk2004 jkbk2004 added the bug Something isn't working label Jul 12, 2024
@jkbk2004 jkbk2004 added No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Jul 12, 2024
@jkbk2004
Copy link
Collaborator Author

@BrianCurtis-NOAA @zach1221 @FernandoAndrade-NOAA This PR is ready.

@zach1221 zach1221 added jenkins-ort run ORT testing and removed jenkins-ort run ORT testing labels Jul 14, 2024
@BrianCurtis-NOAA
Copy link
Collaborator

Acorn can be skipped still.

@zach1221
Copy link
Collaborator

Ok let's start to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants