Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few miscellaneous minor fixes to regression test scripts #2301

Closed

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented May 29, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR includes a number of small changes in rt scripts, mostly code cleanup and changes that reduce the amount of prints to stdout

  1. Print 'ECFLOW Tasks Remaining' message only when the number of tasks changes
  2. Remove explicit 'set -e'. Use -v command line option for verbose mode
  3. Remove 'Computing PET bounds and tasks' message
  4. Fix bugs with log generation script (from @BrianCurtis-NOAA )
  5. Uncomment new_compile=true in rocoto_create_compile_task
  6. Removed unneeded colonifnco

Commit Message:

* UFSWM - A few miscellaneous minor fixes to regression test scripts
 - Print 'ECFLOW Tasks Remaining' message only when the number of tasks changes
 - Remove explicit 'set -e'. Use -v command line option for verbose mode
 - Remove 'Computing PET bounds and tasks' message
 - Fix bugs with log generation script (from @BrianCurtis-NOAA)
 - Uncomment new_compile=true in rocoto_create_compile_task
 - Removed unneeded colonifnco

Priority:

  • Normal

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

DusanJovic-NOAA and others added 7 commits May 16, 2024 14:48
* Update wording on failed tests/compiles, added skipped tests when compile fails and math adjustments, adjusted grep for TIME LIMIT when a compile/test times out.
* removed commented lines and added TIME LIMIT to test section as well
* edit log file info for timeout tests
@DusanJovic-NOAA
Copy link
Collaborator Author

Regression test passed on Hera RegressionTests_hera.log

@jkbk2004
Copy link
Collaborator

@FernandoAndrade-NOAA @zach1221 I think we need to go for testing this pr (not to combine with #2271). @BrianCurtis-NOAA FYI

@zach1221 zach1221 added No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels May 30, 2024
@BrianCurtis-NOAA
Copy link
Collaborator

Do we want to combine this into my WCOSS2 PR ?

@jkbk2004
Copy link
Collaborator

Do we want to combine this into my WCOSS2 PR ?

@BrianCurtis-NOAA Good idea to combine with that! Please, go ahead.

@zach1221 zach1221 removed the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label May 30, 2024
zach1221 pushed a commit that referenced this pull request May 31, 2024
)

* UFSWM - A few miscellaneous minor fixes to regression test scripts
 - Bring in changes for WCOSS2 to match the spack-stack 1.6.0 setup
 - Bring in updated pnetcdf/pio for CICE
 - Print 'ECFLOW Tasks Remaining' message only when the number of tasks changes
 - Remove explicit 'set -e'. Use -v command line option for verbose mode
 - Remove 'Computing PET bounds and tasks' message
 - Fix bugs with log generation script (from @BrianCurtis-NOAA)
 - Uncomment new_compile=true in rocoto_create_compile_task
 - Removed unneeded colonifnco
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants