Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit alpha_fd coefficient to TOFD in UGWPv1 drag suite #2297

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mdtoyNOAA
Copy link
Contributor

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

In ccpp-physics submodule, added explicit 'alpha_fd' coefficient to drag_suite.F90 which corresponds directly to 'alpha' coefficient in Beljaars et al. (QJRMS, 2004), which by default is 12.0. The coefficient will be a runtime namelist option, and can control the strength of the turbulent orographic form drag (TOFD).
Note that the runtime results are bit-for-bit identical to those of the previous version unless a value other than alpha_fd = 12.0 in the namelist.
In ufs-weather-model, updated .gitmodules and added Regressions test log.

Commit Message:

* UFSWM - 
  * FV3 - [PR #840](https://github.com/NOAA-EMC/fv3atm/pull/840)
    * ccpp-physics - [PR #210](https://github.com/ufs-community/ccpp-physics/pull/210)

Priority:

  • High: Time-sensitive project.

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:


Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Regression tests have been performed on Hera with the Intel and Gnu compilers. The tests involving ugwpv1 all passed for both intel and gnu compilers, however, some of the other gnu tests failed. These tests also failed with the previous commit, so failures don't appear to have to do with the code changes in this PR.

Input data Changes:

  • None.

Library Changes/Upgrades:


Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@grantfirl
Copy link
Collaborator

@jkbk2004 This can be closed since it is supposed to be combined into #2290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants