Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop] Update weather model hash to November 21 and UPP hash to November 8 #1162

Merged
merged 5 commits into from
Dec 9, 2024
Merged

[develop] Update weather model hash to November 21 and UPP hash to November 8 #1162

merged 5 commits into from
Dec 9, 2024

Conversation

MichaelLueken
Copy link
Collaborator

@MichaelLueken MichaelLueken commented Dec 2, 2024 •
edited
Loading

DESCRIPTION OF CHANGES:

  • Update UFS-WM hash to 33b3c18 (November 21)
  • Update UPP hash to ce5f3b1 (November 8)
  • Add fix/upp directory
  • Add FIXUPPdir to config_defaults.yaml, scripts/exregional_run_fcst.sh, and scripts/exregional_run_post.sh
  • Add Ben Koziol to the .github/CODEOWNERS file

Type of change

  • New feature (non-breaking change which adds functionality)

TESTS CONDUCTED:

  • derecho.intel - Fundamental, Comprehensive, and Fire sample config (ush/config.fire.yaml) tests were run
  • gaea.intel - Fundamental and Comprehensive WE2E test suites were run
  • hera.gnu - Fundamental and Comprehensive WE2E tests suites were run
  • hera.intel - Fundamental, Comprehensive, AQM WE2E, and AQM sample config (ush/config.aqm.yaml) tests were run
  • hercules.intel - Fundamental, Comprehensive, AQM WE2E, and AQM sample config (ush/config.aqm.yaml) tests were run
  • jet.intel - Fundamental, Comprehensive, and 2 Fire WE2E tests were run
  • orion.intel - Fundamental, Comprehensive, AQM WE2E, and AQM sample config (ush/config.aqm.yaml) tests were run
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • My changes generate no new warnings
  • New and existing tests pass with my changes

MichaelLueken and others added 2 commits December 2, 2024 11:05
@MichaelLueken
[feature/hash_update]:
80d7404 
 * Externals.cfg - Update UFS-WM hash to 33b3c18 (November 21) and UPP hash to ce5f3b1 (November 8)
 * doc/ContribGuide/contributing.rst - Update anchor for creating a fork
 * doc/UsersGuide/CustomizingTheWorkflow/ConfigWorkflow.rst - Add new FIXUPPdir from ush/config_defaults.yaml
 * fix/upp - Path to sorc/UPP/fix
 * scripts/exregional_run_fcst.sh - Ensure new UPP fix file is using FIXUPPdir
 * scripts/exregional_run_post.sh - Same
 * ush/config_defaults.yaml - Add new FIXUPPdir to point to UPP fixed file directory.
@MichaelLueken
[feature/hash_update] Add Ben Koziol to the CODEOWNERS file
4d478ea
@MichaelLueken MichaelLueken marked this pull request as ready for review December 2, 2024 17:54
@MichaelLueken
Copy link
Collaborator Author

Please note the addition of the fix/upp directory in this update. The nam_micro_lookup.dat file was moved from sorc/UPP/parm to sorc/UPP/fix, necessitating the addition of the fix/upp directory and FIXUPPdir entry in config_defaults.yaml. I am open to discussion regarding how to handle this, if what has been done for this PR isn't sufficient.

RatkoVasic-NOAA
RatkoVasic-NOAA approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

@MichaelLueken
[feature/hash_update]:
7e6bc17 
 * doc/UsersGuide/CustomizingTheWorkflow/ConfigWorkflow.rst - Remove FIXUPPdir
 * fix/upp - Removed symlink pointing to full sorc/UPP/fix
 * fix/upp/nam_micro_lookup.dat - Add symlink point to single file from sorc/UPP/fix
 * scripts/exregional_run_fcst.sh - Replace FIXUPPdir with ${HOMEdir}/fix/upp
 * scripts/exregional_run_post.sh - Same
 * ush/config_defaults.yaml - Remove FIXUPPdir
@MichaelLueken
Copy link
Collaborator Author

Instead of linking the entire sorc/UPP/fix to fix/upp, I'm only linking the sorc/UPP/fix/nam_micro_lookup.dat file into fix/upp/nam_micro_lookup.dat.

Following this update, WE2E test suites were rerun on Hera -

Fundamental:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              13.30
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20241  COMPLETE               9.52
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              26.26
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024120  COMPLETE              44.30
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20241205183  COMPLETE              24.78
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024120518335  COMPLETE              47.86
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             166.02

Comprehensive:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
2020_CAD_20241205190527                                            COMPLETE              70.53
2020_CAPE_20241205190528                                           COMPLETE              73.95
2019_hurricane_barry_20241205190529                                COMPLETE              75.51
2019_halloween_storm_20241205190530                                COMPLETE              76.70
2019_hurricane_lorenzo_20241205190530                              COMPLETE              68.43
2019_memorial_day_heat_wave_20241205190531                         COMPLETE              64.10
2020_denver_radiation_inversion_20241205190532                     COMPLETE              77.27
2020_easter_storm_20241205190533                                   COMPLETE              85.12
2020_jan_cold_blast_20241205190533                                 COMPLETE              66.82
community_20241205190534                                           COMPLETE              40.66
custom_ESGgrid_20241205190535                                      COMPLETE              30.39
custom_ESGgrid_Central_Asia_3km_20241205190536                     COMPLETE              57.72
custom_ESGgrid_Great_Lakes_snow_8km_20241205190536                 COMPLETE              23.29
custom_ESGgrid_IndianOcean_6km_20241205190538                      COMPLETE              31.53
custom_ESGgrid_NewZealand_3km_20241205190539                       COMPLETE             138.19
custom_ESGgrid_Peru_12km_20241205190539                            COMPLETE              42.17
custom_ESGgrid_SF_1p1km_20241205190540                             COMPLETE            1636.52
custom_GFDLgrid__GFDLgrid_USE_NUM_CELLS_IN_FILENAMES_eq_FALSE_202  COMPLETE              13.69
custom_GFDLgrid_20241205190542                                     COMPLETE              12.92
deactivate_tasks_20241205190542                                    COMPLETE               1.38
get_from_AWS_ics_GEFS_lbcs_GEFS_fmt_grib2_2022040400_ensemble_2me  COMPLETE            1717.91
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_grib2_2019061200_2024120  COMPLETE              10.09
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_nemsio_2019061200_202412  COMPLETE              12.75
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_nemsio_2021032018_202412  COMPLETE              12.98
get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_netcdf_2022060112_48h_20  COMPLETE             164.94
get_from_HPSS_ics_GDAS_lbcs_GDAS_fmt_netcdf_2022040400_ensemble_2  COMPLETE            1839.06
get_from_HPSS_ics_GSMGFS_lbcs_GSMGFS_20241205190547                COMPLETE              11.16
get_from_HPSS_ics_HRRR_lbcs_RAP_20241205190548                     COMPLETE              29.14
get_from_HPSS_ics_RAP_lbcs_RAP_20241205190549                      COMPLETE              33.30
get_from_NOMADS_ics_FV3GFS_lbcs_FV3GFS_20241205190550              COMPLETE              16.48
grid_CONUS_25km_GFDLgrid_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_202  COMPLETE              14.82
grid_CONUS_3km_GFDLgrid_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_  COMPLETE             627.66
grid_RRFS_AK_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20241  COMPLETE             157.18
grid_RRFS_AK_3km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_20241205190553  COMPLETE             436.43
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20241205190  COMPLETE              53.15
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20  COMPLETE              74.23
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2024120519  COMPLETE              59.12
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_202  COMPLETE              60.38
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20241  COMPLETE               8.16
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20  COMPLETE              28.03
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              28.39
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2024120519  COMPLETE              12.52
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20241205190  COMPLETE              57.62
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_202  COMPLETE              33.61
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_RAP_20241205190603  COMPLETE              15.41
grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2_20241  COMPLETE              10.85
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024120519060  COMPLETE              51.80
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_RRFS_v1beta_202412051  COMPLETE              31.22
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_202412  COMPLETE             553.53
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson  COMPLETE             765.96
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_20241205  COMPLETE             719.37
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_20241205190  COMPLETE             846.81
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta_2024  COMPLETE            1019.80
grid_RRFS_CONUScompact_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_  COMPLETE              60.26
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_HRRR_20241205  COMPLETE              58.41
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              59.45
grid_RRFS_CONUScompact_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_  COMPLETE              15.79
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024120  COMPLETE              52.06
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              21.60
grid_RRFS_CONUScompact_25km_ics_RRFS_lbcs_RRFS_suite_RRFS_v1beta_  COMPLETE              19.97
grid_RRFS_CONUScompact_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_2  COMPLETE             628.77
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_HRRR_202412051  COMPLETE             731.04
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_20  COMPLETE             809.54
grid_RRFS_NA_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20241205190619  COMPLETE             181.42
grid_SUBCONUS_Ind_3km_ics_FV3GFS_lbcs_FV3GFS_suite_WoFS_v0_202412  COMPLETE              65.23
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024120519062  COMPLETE              38.65
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20241205190  COMPLETE              34.61
grid_SUBCONUS_Ind_3km_ics_NAM_lbcs_NAM_suite_GFS_v16_202412051906  COMPLETE              46.02
grid_SUBCONUS_Ind_3km_ics_RAP_lbcs_RAP_suite_RRFS_v1beta_plot_202  COMPLETE              21.73
long_fcst_20241205190626                                           COMPLETE             160.97
MET_ensemble_verification_only_vx_20241205190627                   COMPLETE               1.13
MET_ensemble_verification_only_vx_time_lag_20241205190630          COMPLETE               4.31
MET_ensemble_verification_winter_wx_20241205190633                 COMPLETE             227.78
MET_verification_only_vx_20241205190635                            COMPLETE               0.28
pregen_grid_orog_sfc_climo_20241205190638                          COMPLETE              11.20
specify_EXTRN_MDL_SYSBASEDIR_ICS_LBCS_20241205190640               COMPLETE              10.24
specify_template_filenames_20241205190641                          COMPLETE              11.20
vx-det_long-fcst_custom-vx-config_aiml-fourcastnet_20241205190641  COMPLETE               0.65
vx-det_long-fcst_custom-vx-config_aiml-graphcast_20241205190644    COMPLETE               0.67
vx-det_long-fcst_custom-vx-config_aiml-panguweather_2024120519064  COMPLETE               0.68
vx-det_long-fcst_custom-vx-config_gfs_20241205190649               COMPLETE               0.70
vx-det_long-fcst_winter-wx_SRW-staged_20241205190651               COMPLETE               1.14
vx-det_multicyc_fcst-overlap_ncep-hrrr_20241205190654              COMPLETE               3.59
vx-det_multicyc_first-obs-00z_ncep-hrrr_20241205190656             COMPLETE               0.77
vx-det_multicyc_last-obs-00z_ncep-hrrr_20241205190659              COMPLETE               0.85
vx-det_multicyc_long-fcst-no-overlap_nssl-mpas_20241205190701      COMPLETE              13.15
vx-det_multicyc_long-fcst-overlap_nssl-mpas_20241205190704         COMPLETE              12.09
vx-det_multicyc_no-00z-obs_nssl-mpas_20241205190706                COMPLETE               0.77
vx-det_multicyc_no-fcst-overlap_ncep-hrrr_20241205190708           COMPLETE               1.91
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE           15509.38

UFS Fire:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
UFS_FIRE_multifire_one-way-coupled_20241205215219                  COMPLETE              14.58
UFS_FIRE_one-way-coupled_20241205215222                            COMPLETE              14.56
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE              29.14

AQM WE2E:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
aqm_grid_AQM_NA13km_suite_GFS_v16_20241206141517                   COMPLETE            2741.48
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            2741.48

rickgrubin-noaa
rickgrubin-noaa approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@rickgrubin-noaa rickgrubin-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Dec 6, 2024
@MichaelLueken
Copy link
Collaborator Author

The Jenkins tests successfully passed, so I will now merge this work into develop.

@MichaelLueken MichaelLueken merged commit 207f2a6 into ufs-community:develop Dec 9, 2024
5 of 6 checks passed
@MichaelLueken MichaelLueken deleted the feature/hash_update branch December 9, 2024 15:22
@MichaelLueken MichaelLueken mentioned this pull request Dec 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickgrubin-noaa rickgrubin-noaa rickgrubin-noaa approved these changes

@RatkoVasic-NOAA RatkoVasic-NOAA RatkoVasic-NOAA approved these changes

@mkavulich mkavulich Awaiting requested review from mkavulich mkavulich is a code owner

@gsketefian gsketefian Awaiting requested review from gsketefian gsketefian is a code owner

@JeffBeck-NOAA JeffBeck-NOAA Awaiting requested review from JeffBeck-NOAA JeffBeck-NOAA is a code owner

@BenjaminBlake-NOAA BenjaminBlake-NOAA Awaiting requested review from BenjaminBlake-NOAA BenjaminBlake-NOAA is a code owner

@ywangwof ywangwof Awaiting requested review from ywangwof ywangwof is a code owner

@chan-hoo chan-hoo Awaiting requested review from chan-hoo chan-hoo is a code owner

@panll panll Awaiting requested review from panll panll is a code owner

@christinaholtNOAA christinaholtNOAA Awaiting requested review from christinaholtNOAA christinaholtNOAA is a code owner

@christopherwharrop-noaa christopherwharrop-noaa Awaiting requested review from christopherwharrop-noaa christopherwharrop-noaa is a code owner

@danielabdi-noaa danielabdi-noaa Awaiting requested review from danielabdi-noaa danielabdi-noaa is a code owner

@mark-a-potts mark-a-potts Awaiting requested review from mark-a-potts mark-a-potts is a code owner

@jkbk2004 jkbk2004 Awaiting requested review from jkbk2004 jkbk2004 is a code owner

@willmayfield willmayfield Awaiting requested review from willmayfield willmayfield is a code owner

@dmwright526 dmwright526 Awaiting requested review from dmwright526 dmwright526 is a code owner

@gspetro-NOAA gspetro-NOAA Awaiting requested review from gspetro-NOAA gspetro-NOAA is a code owner

@natalie-perlin natalie-perlin Awaiting requested review from natalie-perlin natalie-perlin is a code owner

@EdwardSnyder-NOAA EdwardSnyder-NOAA Awaiting requested review from EdwardSnyder-NOAA EdwardSnyder-NOAA is a code owner

@BruceKropp-Raytheon BruceKropp-Raytheon Awaiting requested review from BruceKropp-Raytheon BruceKropp-Raytheon is a code owner

Assignees
No one assigned
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelLueken @RatkoVasic-NOAA @rickgrubin-noaa