Support Intel LLVM compiler (ifx) #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Intel LLVM compiler (ifx) error: physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90(237): error #8284: If the actual argument is scalar, the dummy argument shall be scalar unless the actual argument is of type character or is an element of an array that is not assumed shape, pointer, or polymorphic. [SIG1T] CALL SFCCYCLE (9998, npts, max(lsoil,lsoil_lsm), sig1t, fhcyc, & -----------^
DusanJovic-NOAA
requested review from
grantfirl,
Qingfu-Liu,
dustinswales,
AnningCheng-NOAA,
andrewgettelman and
mzhangw
as code owners
This was referenced Jul 19, 2024
AnningCheng-NOAA
approved these changes
Jul 24, 2024
grantfirl
approved these changes
Aug 7, 2024
climbfuji
approved these changes
Aug 7, 2024
Qingfu-Liu
approved these changes
Aug 22, 2024
add Rhae Sung Kim to CODEOWNERS file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Intel LLVM compiler.
Changes:
module_mp_nssl_2mom.F90is added to the list of files that are compiled with lower optimization because it takes very-very long time to compile it.SIG1Tingcycle.F90is declared to be one-dimensional array, same as dummy argument inSFCCYCLEsubroutine. See commit d6490c5.aerinterp.F90. For details see this issue Compiler crash in physics/aerinterp.F90 with Intel oneAPI compilers (ifx) NCAR/ccpp-physics#1003