Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convective Reflectivity #129

Merged
merged 10 commits into from
Dec 1, 2023

Conversation

ericaligo-NOAA
Copy link
Collaborator

@ericaligo-NOAA ericaligo-NOAA commented Nov 14, 2023

[@RuiyuSun] and I compute convective reflectivity for Thompson or NSSL microphysics and with GF deep, shallow or SAS deep convection. I removed the calculation that was in cu_gf_driver_post.F90 and cu_gf_driver_post.meta, and associated parameters, and added the code to GFS_MP_generic_post.F90. The 3D refl_10cm array will be changed. In the process of creating a new baseline. I had to modify regional.nml.IN and change imfhalcnv and imfdeepconv from 2 to -1 otherwise the code would try to calculate convective reflectivity despite no calls for deep/shallow convection.

RegressionTests_hera.log
RegressionTests_hera_newbaseline.log

@haiqinli
Copy link
Collaborator

@ericaligo-NOAA Is it possible to apply the following conditions (from cu_gf_driver_post.F90) when applying GF convection? Thanks.

line 73 if(cuprate .lt. 0.05) cuprate=0.
line 75. if (maxupmf(i).gt.0.1 .and. cuprate.gt.0.) then

@ericaligo-NOAA
Copy link
Collaborator Author

ericaligo-NOAA commented Nov 16, 2023 via email

@ericaligo-NOAA
Copy link
Collaborator Author

@ericaligo-NOAA Is it possible to apply the following conditions (from cu_gf_driver_post.F90) when applying GF convection? Thanks.

line 73 if(cuprate .lt. 0.05) cuprate=0. line 75. if (maxupmf(i).gt.0.1 .and. cuprate.gt.0.) then

Thanks for the comments! I had shown previously that with the conditions included there is inconsistency between the precipitation and reflectivity. See this presentation and more specifically the links on slide 12 to see animations of various fields. I attached one example here. In the example here, the lower left plot is the hourly max precipitation rate valid at 15UTC 08 July 2020. The bottom center plot is the hourly max 1km agl reflectivity valid at the same time with those conditions you noted, and the bottom right is the hourly max 1km agl reflectivity without those conditions. We can see here that we have consistency between precip and reflectivity when we leave out those conditions. Additionally, it would make it difficult to compare reflectivity between GF and saSAS with those conditions.
Eric
frame39

@haiqinli
Copy link
Collaborator

@ericaligo-NOAA Thank you very much for your information!

@dustinswales
Copy link
Collaborator

I think it's a great idea to pull these reflectivity calculations out of the convection scheme, but I'm not sure if GFS_MP_generic_post.F90 is the ideal place for them, since they rely on both the convection and mp parameterizations. May I suggest to add them to GFS_physics_post.F90? (This was recently created as a landing spot for computations on multiple schemes.)

@ericaligo-NOAA
Copy link
Collaborator Author

ericaligo-NOAA commented Nov 16, 2023 via email

@dustinswales
Copy link
Collaborator

@ericaligo-NOAA Good point.
At some point I will be doing some more reorganization/isolating of the diagnostics, at which point I may put maximum_hourly_diagnostics into GFS_physics_post, along with other diagnostic calculations in the physics.

@grantfirl
Copy link
Collaborator

@haiqinli Should this same thing be done in the C3 scheme?

@haiqinli
Copy link
Collaborator

@grantfirl Thanks for your good point. Yes, this same thing should also be done for C3.

@yangfanglin
Copy link
Collaborator

@grantfirl Thanks for your good point. Yes, this same thing should also be done for C3.

I'd suggest we do not include C3 in this PR since we need to get this PR committed asap to meet the deadline of the first round of RRFS code freeze.

@grantfirl
Copy link
Collaborator

@grantfirl Thanks for your good point. Yes, this same thing should also be done for C3.

I'd suggest we do not include C3 in this PR since we need to get this PR committed asap to meet the deadline of the first round of RRFS code freeze.

OK. I can add an issue to remember to do this in a later PR.

@grantfirl
Copy link
Collaborator

@grantfirl Thanks for your good point. Yes, this same thing should also be done for C3.

I'd suggest we do not include C3 in this PR since we need to get this PR committed asap to meet the deadline of the first round of RRFS code freeze.

@yangfanglin Do you know when the deadline is for the code freeze? As of now, this is scheduled for merge after Thanksgiving. Is this acceptable? If not, we can try to push is earlier.

@yangfanglin
Copy link
Collaborator

@grantfirl the target is December 1 for RRFS Beta evaluation soft freeze

Merge branch 'ufs/dev' into feature/refconv
Merge branch 'ufs/dev' into feature/refconv
Merge branch 'ufs/dev' into feature/refconv
@zach1221
Copy link

zach1221 commented Dec 1, 2023

Testing is complete on ufs-wm #1996, @grantfirl can you please merge this ccpp-physics PR for us?

@grantfirl grantfirl merged commit c0aa212 into ufs-community:ufs/dev Dec 1, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants