Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembler v1.4 #17

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Assembler v1.4 #17

wants to merge 20 commits into from

Conversation

Rian-Ismael
Copy link
Collaborator

No description provided.

GeraldoSJr
GeraldoSJr requested changes Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@GeraldoSJr GeraldoSJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the code does one thing, it has too many nested functions, which create some what of a bad smell to it, it would probably be a good idea to separate the code into a package, and break it down into small, single responsability, parts.

assembler/main.go Outdated Show resolved Hide resolved
GeraldoSJr
GeraldoSJr requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@GeraldoSJr GeraldoSJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the functs calls throw out the code

assembler/assembler.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagomanel thiagomanel Awaiting requested review from thiagomanel

@GeraldoSJr GeraldoSJr Awaiting requested review from GeraldoSJr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rian-Ismael @GeraldoSJr