Decode functions #15
Open
Decode functions #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagomanel
reviewed
Sep 20, 2024
thiagomanel
reviewed
Sep 20, 2024
thiagomanel
requested changes
Sep 20, 2024
GeraldoSJr
approved these changes
Sep 21, 2024
GeraldoSJr
requested changes
Sep 24, 2024
| offsetOpcode := word - opcodeLength | ||
| opcode := instruction >> (uint32(offsetOpcode)) | ||
|
|
||
| return Opcode(opcode) |
There was a problem hiding this comment.
This function should return an error if the opcode provided cannot be mapped to one of the options, even if the assembler checks this on a higher level changes will happen and is safe to add this check.
| } | ||
|
|
||
| func (m *Machine) decode() {} | ||
| func (m *Machine) decodeRTypeInst(instruction uint32) Instruction { |
There was a problem hiding this comment.
Should return an error checking the operands
| } | ||
|
|
||
| func (m *Machine) decodeITypeInst(instruction uint32) Instruction { | ||
| offsetOpcode := word - opcodeLength |
There was a problem hiding this comment.
Should return an error checking the operands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.