Performing tasks on a remote worker with Docker. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagomanel
requested changes
Jun 3, 2019
There was a problem hiding this comment.
thanks @wesleymonte
overall, the code seems ok to me. However, I submitted a bunch of small comments. Any doubt, talk to me directly
src/main/java/org/fogbowcloud/arrebol/execution/DockerTaskExecutor.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public void setRequirements(Map<String, String> requirements) { | ||
| this.requirements = requirements; |
| this.requirements = requirements; | ||
| } | ||
|
|
||
| protected void setImage(String image){ |
| public String start() throws Exception { | ||
| String containerId = this.containerRequestHelper.createContainer(); | ||
| this.containerRequestHelper.startContainer(); | ||
| LOGGER.info("Started the container " + this.containerName); |
There was a problem hiding this comment.
should log address and name (in all the places we have only one of them)
| return execInstanceResult; | ||
| } | ||
|
|
||
| public void setRequirements(Map<String, String> requirements){ |
| this.containerRequestHelper.setRequirements(requirements); | ||
| } | ||
|
|
||
| public void setImage(String image){ |
Hotfix/fixed pull image
…g-lsd/arrebol into feature/check-commands-state
Feature/check commands state
Feature/check commands tests.
Added stderr to exec instance
Feature/docker script
Feature/worker deployment
Enhancement of deploy doc
Updated deploy doc
Hotfix/arrebol k8s doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.