forked from DSpace/DSpace
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merging dataquest-dev/dtq dev #1136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added flyway file to insert default licenses with license labels and mappings * Added required header
* Updated table workspace with share token, created endpoint to generate share token and it is sent via email * Added method to get workspaceitem via share token. * Added an endpoint for changing the submission's owner. * Added license headers * Added test for fetching item with share Token * Added tests to check the owner is changed * Added better explanation why the BE must return Page object in the search endpoint * Validate the user in the SubmissionController, it cannot be null * Updated email - some values are fetched directly from the configuration property * Updated preAuthorization method to ADD instead of WRITE (write is used for controlling authorization for modifying the Item) and updated shareURL * Authorize the submitter which is trying to take sharing item via shareToken. * Update integration test following the feature update
* problem with language code * fix amount and sizeUnitOther rest-tests errors * added language coding * new language and funding project mishmash array position * added isoCodes
…#807) * Fetch netid as array from the cfg. Now netid as array is used everywhere. Added integration test to ask for an email when the user send only persistent-id in the shib header. * Fixed checkstyle issue * The user is not signed in without using link with the verification token from the email/ (#809) * UFAL/Shibboleth - show error in the UI when shibboleth authentication is failed (#810) * The user is not signed in without using link with the verification token from the email/ * Send a redirect to UI with specific parameter that the Shibboleth authorization wasn't successful
* Added solr index `handle_title_ac` and `_comp` for the Item * Added support for searching results from specific solr indexes. 1. Updated submission-forms autocomplete definition to specify a specific index. 2. Updated configuration is provided via REST API. 3. Create a new `/suggestions` endpoint for searching values from custom solr index - it returns VocabularyEntry page. * Supported searching Item byHandle when passed a handle as parameter without handle canonical prefix. * Added autocompleteCustom `solr-subject_ac` and `handle_title_ac`. * Added autocompleteCustom `solr-publisher_ac`. * Added cfg property to define a separator from the solr value to get only display value. * Added autocompleteCustom `solr-dataProvider_ac` * Refactored code and created integration test for the SuggestionRestController * Updated suggestion integration tests because it has had a conflict with another IT * Added doc and changed `autocomplete.custom.format` to `autocomplete.custom.separator` for proper naming. * Added support for loading suggestions from the json file - need to refactor. * Refactored and added docs. * Created tests and fixed failing ones due to updated solr definition * Synchronized submission-forms_cs.xml with the original-english one * Added docs about magic constants * Added doc why the handle is updated to canonical form in the searchbyHandle endpoint * Allow searching only within the solr indexes or JSON files permitted by the configuration. * Removed normalization of handle prefix because there could be more prefixes. Expect only handle value. * Fixed if condition and config property default value. * Fixed integration tests. Allowed autocomplete custom was missing in the test cfg. * The suggestion endpoint is allowed only for authorized users * Refactored method for the normalizing the query for the discoverQuery and added unit tests.
) * Changed position of rows in submission-forms.xml following v5 * Fixed the alignment of some text * Removed rows which are not in the v5 * Removed license selector from the `teaching` and `clariah-data` collections * Updated input differences in the submission-forms.xml following the v5. --------- Co-authored-by: Juraj Roka <[email protected]> Co-authored-by: milanmajchrak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this merge contains the following changes:
Add default licenses - from ZCU update (dataquest-dev#801)
UFAL/share submission by email (dataquest-dev#780)
Import default licenses only if the license tables are empty. (dataquest-dev#808)
UFAL/Shibboleth - netid-header should use getArrayProperty everywhere (dataquest-dev#807)
UFAL/Autocomplete enhancement (dataquest-dev#768)
Oai elg crosswalk (dataquest-dev#798)
removed handle from item submission (dataquest-dev#812)
UFAL/Changed position of rows in submission-forms.xml following v5 (dataquest-dev#802)