-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dar feedback para o user (facebook) #292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: update dependencies (#201) * chore: update dependencies * chore: checkout actions v4 * fix: teachers form (#200) * chore: adjust types and fix aliasInitials bugh * draft: facebook fix * refactor: auth route guard * draft: facebook impl * feat: better css * fix: update index url * fix: remove eslint disable and todo comment * feat: relative path fb link --------- Co-authored-by: Renan Zago Lorijola <[email protected]> Co-authored-by: Mateus Braga <[email protected]> Co-authored-by: RenanLorijola <[email protected]>
Joabesv
reviewed
Feb 15, 2024
Joabesv
reviewed
Feb 15, 2024
Joabesv
changed the title
feat: dar feedback para o user
feat: dar feedback para o user (facebook)
Feb 16, 2024
Joabesv
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
RenanLorijola
added a commit
that referenced
this pull request
Feb 16, 2024
* chore: update packages from root * fix: facebook login (#194) * chore: update dependencies (#201) * chore: update dependencies * chore: checkout actions v4 * fix: teachers form (#200) * chore: adjust types and fix aliasInitials bugh * draft: facebook fix * refactor: auth route guard * draft: facebook impl * feat: better css * fix: update index url * fix: remove eslint disable and todo comment * feat: relative path fb link --------- Co-authored-by: Renan Zago Lorijola <[email protected]> Co-authored-by: Mateus Braga <[email protected]> Co-authored-by: RenanLorijola <[email protected]> * fix: calengrade issues (#250) * fix: facebook error handling * refac: reorder stuff on script tag * fix: 'home' to 'pagina inicial' --------- Co-authored-by: RenanLorijola <[email protected]> Co-authored-by: Joabe Silva <[email protected]> Co-authored-by: Renan Zago Lorijola <[email protected]> Co-authored-by: Joabesv <[email protected]>
Joabesv
added a commit
that referenced
this pull request
Feb 16, 2024
* chore: update packages from root * fix: facebook login (#194) * chore: update dependencies (#201) * chore: update dependencies * chore: checkout actions v4 * fix: teachers form (#200) * chore: adjust types and fix aliasInitials bugh * draft: facebook fix * refactor: auth route guard * draft: facebook impl * feat: better css * fix: update index url * fix: remove eslint disable and todo comment * feat: relative path fb link --------- Co-authored-by: Renan Zago Lorijola <[email protected]> Co-authored-by: Mateus Braga <[email protected]> Co-authored-by: RenanLorijola <[email protected]> * fix: calengrade issues (#250) * fix: facebook error handling * refac: reorder stuff on script tag * fix: 'home' to 'pagina inicial' --------- Co-authored-by: RenanLorijola <[email protected]> Co-authored-by: Joabe Silva <[email protected]> Co-authored-by: Renan Zago Lorijola <[email protected]> Co-authored-by: Joabesv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrição
Ao tentar autenticar uma conta que não existe no UFABC Next, mostra um toast e uma telinha sugerindo realizar uma conta com a autenticação do Google pela home do site.
Como testar esse PR
Só rodar o projeto normal com
yarn dev
e depois acessar a rotaautenticar-facebook
Screenshot