Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dar feedback para o user (facebook) #292

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

mateusbrg
Copy link
Member

Descrição

Ao tentar autenticar uma conta que não existe no UFABC Next, mostra um toast e uma telinha sugerindo realizar uma conta com a autenticação do Google pela home do site.

Como testar esse PR

Só rodar o projeto normal com yarn dev e depois acessar a rota autenticar-facebook

Screenshot

Screenshot from 2024-02-15 00-10-50

RenanLorijola and others added 4 commits November 27, 2023 01:48
* chore: update dependencies (#201)

* chore: update dependencies

* chore: checkout actions v4

* fix: teachers form (#200)

* chore: adjust types and fix aliasInitials bugh

* draft: facebook fix

* refactor: auth route guard

* draft: facebook impl

* feat: better css

* fix: update index url

* fix: remove eslint disable and todo comment

* feat: relative path fb link

---------

Co-authored-by: Renan Zago Lorijola <[email protected]>
Co-authored-by: Mateus Braga <[email protected]>
Co-authored-by: RenanLorijola <[email protected]>
@mateusbrg mateusbrg requested a review from Joabesv February 15, 2024 03:15
@Joabesv Joabesv added the ready for review PR is ready for review label Feb 15, 2024
@Joabesv Joabesv changed the title fix: facebook error handling feat: dar feedback para o user Feb 16, 2024
@Joabesv Joabesv changed the title feat: dar feedback para o user feat: dar feedback para o user (facebook) Feb 16, 2024
@Joabesv Joabesv changed the base branch from main to develop February 16, 2024 03:33
Copy link
Member

@Joabesv Joabesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mateusbrg mateusbrg merged commit 5f1757e into develop Feb 16, 2024
4 checks passed
@mateusbrg mateusbrg deleted the fix/handling-facebook-error branch February 16, 2024 03:40
RenanLorijola added a commit that referenced this pull request Feb 16, 2024
* chore: update packages from root

* fix: facebook login (#194)

* chore: update dependencies (#201)

* chore: update dependencies

* chore: checkout actions v4

* fix: teachers form (#200)

* chore: adjust types and fix aliasInitials bugh

* draft: facebook fix

* refactor: auth route guard

* draft: facebook impl

* feat: better css

* fix: update index url

* fix: remove eslint disable and todo comment

* feat: relative path fb link

---------

Co-authored-by: Renan Zago Lorijola <[email protected]>
Co-authored-by: Mateus Braga <[email protected]>
Co-authored-by: RenanLorijola <[email protected]>

* fix: calengrade issues (#250)

* fix: facebook error handling

* refac: reorder stuff on script tag

* fix: 'home' to 'pagina inicial'

---------

Co-authored-by: RenanLorijola <[email protected]>
Co-authored-by: Joabe Silva <[email protected]>
Co-authored-by: Renan Zago Lorijola <[email protected]>
Co-authored-by: Joabesv <[email protected]>
Joabesv added a commit that referenced this pull request Feb 16, 2024
* chore: update packages from root

* fix: facebook login (#194)

* chore: update dependencies (#201)

* chore: update dependencies

* chore: checkout actions v4

* fix: teachers form (#200)

* chore: adjust types and fix aliasInitials bugh

* draft: facebook fix

* refactor: auth route guard

* draft: facebook impl

* feat: better css

* fix: update index url

* fix: remove eslint disable and todo comment

* feat: relative path fb link

---------

Co-authored-by: Renan Zago Lorijola <[email protected]>
Co-authored-by: Mateus Braga <[email protected]>
Co-authored-by: RenanLorijola <[email protected]>

* fix: calengrade issues (#250)

* fix: facebook error handling

* refac: reorder stuff on script tag

* fix: 'home' to 'pagina inicial'

---------

Co-authored-by: RenanLorijola <[email protected]>
Co-authored-by: Joabe Silva <[email protected]>
Co-authored-by: Renan Zago Lorijola <[email protected]>
Co-authored-by: Joabesv <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants