fix: calengrade issues #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Joabesv
added
bug
RenanLorijola
force-pushed
the
fix/calengrade-file
branch
from
346f1fb to
d104c5e
Compare
RenanLorijola
added a commit
that referenced
this pull request
Jan 5, 2024
mateusbrg
added a commit
that referenced
this pull request
Feb 16, 2024
* chore: update packages from root * fix: facebook login (#194) * chore: update dependencies (#201) * chore: update dependencies * chore: checkout actions v4 * fix: teachers form (#200) * chore: adjust types and fix aliasInitials bugh * draft: facebook fix * refactor: auth route guard * draft: facebook impl * feat: better css * fix: update index url * fix: remove eslint disable and todo comment * feat: relative path fb link --------- Co-authored-by: Renan Zago Lorijola <[email protected]> Co-authored-by: Mateus Braga <[email protected]> Co-authored-by: RenanLorijola <[email protected]> * fix: calengrade issues (#250) * fix: facebook error handling * refac: reorder stuff on script tag * fix: 'home' to 'pagina inicial' --------- Co-authored-by: RenanLorijola <[email protected]> Co-authored-by: Joabe Silva <[email protected]> Co-authored-by: Renan Zago Lorijola <[email protected]> Co-authored-by: Joabesv <[email protected]>
RenanLorijola
added a commit
that referenced
this pull request
Feb 16, 2024
* chore: update packages from root * fix: facebook login (#194) * chore: update dependencies (#201) * chore: update dependencies * chore: checkout actions v4 * fix: teachers form (#200) * chore: adjust types and fix aliasInitials bugh * draft: facebook fix * refactor: auth route guard * draft: facebook impl * feat: better css * fix: update index url * fix: remove eslint disable and todo comment * feat: relative path fb link --------- Co-authored-by: Renan Zago Lorijola <[email protected]> Co-authored-by: Mateus Braga <[email protected]> Co-authored-by: RenanLorijola <[email protected]> * fix: calengrade issues (#250) * fix: facebook error handling * refac: reorder stuff on script tag * fix: 'home' to 'pagina inicial' --------- Co-authored-by: RenanLorijola <[email protected]> Co-authored-by: Joabe Silva <[email protected]> Co-authored-by: Renan Zago Lorijola <[email protected]> Co-authored-by: Joabesv <[email protected]>
Joabesv
added a commit
that referenced
this pull request
Feb 16, 2024
* chore: update packages from root * fix: facebook login (#194) * chore: update dependencies (#201) * chore: update dependencies * chore: checkout actions v4 * fix: teachers form (#200) * chore: adjust types and fix aliasInitials bugh * draft: facebook fix * refactor: auth route guard * draft: facebook impl * feat: better css * fix: update index url * fix: remove eslint disable and todo comment * feat: relative path fb link --------- Co-authored-by: Renan Zago Lorijola <[email protected]> Co-authored-by: Mateus Braga <[email protected]> Co-authored-by: RenanLorijola <[email protected]> * fix: calengrade issues (#250) * fix: facebook error handling * refac: reorder stuff on script tag * fix: 'home' to 'pagina inicial' --------- Co-authored-by: RenanLorijola <[email protected]> Co-authored-by: Joabe Silva <[email protected]> Co-authored-by: Renan Zago Lorijola <[email protected]> Co-authored-by: Joabesv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrição
Corrigindo problemas das datas dos eventos gerados no nosso calengrade por conta de migração de bibliotecas e refatoração sem os devidos testes.
Tickets relacionados
#235
Como testar esse PR
Gere um arquivo ics no calengrade antigo e em seguida gere no nosso, baixe ambos os arquivos, execute um diff entre os arquivos ou abra-os com um editor de texto e cole num diff checker online (exemplo) e verifique que somente os campos de UID (id unico do evento) e timestamp (horário que o evento foi criado) tem valores diferentes. Também pode-se gerar o calengrade e colocar na sua agenda, verificando se os horários e dias estão corretos.
Screen.Recording.2023-12-28.at.01.34.29.mov
Adicionou/atualizou testes automatizados?