Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http.Serverはcontextがdoneしたときにいい感じにエラーを返してくれない #243

Merged
merged 3 commits into from
Nov 21, 2023
Merged

http.Serverはcontextがdoneしたときにいい感じにエラーを返してくれない #243

merged 3 commits into from
Nov 21, 2023

Conversation

Azuki-bar
Copy link
Member

close #242

@Azuki-bar Azuki-bar requested a review from csenet November 21, 2023 08:02
@github-actions github-actions bot added the backend バックエンド関連 label Nov 21, 2023
Azuki-bar
Azuki-bar commented Nov 21, 2023
View reviewed changes
backend/state-manager/cmd/main.go
})

// errGroup.Waitはeg.Goが全てerrorを返すまでwaitする
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今回の場合はeg.Go(srv.ListenAndServe)がエラーを返さなかったので起こった事象ですね～

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど

@Azuki-bar Azuki-bar merged commit 61c8192 into main Nov 21, 2023
3 checks passed
@Azuki-bar Azuki-bar deleted the handle-ctrl-c-truely branch November 21, 2023 08:21
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csenet csenet csenet approved these changes

Assignees
No one assigned
Labels
backend バックエンド関連
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ctrl + Cでプロセスが終了しない
2 participants
@Azuki-bar @csenet