Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

アーキテクチャ図の更新 #152

Merged
merged 2 commits into from
Oct 9, 2023
Merged

アーキテクチャ図の更新 #152

merged 2 commits into from
Oct 9, 2023

Conversation

csenet
Copy link
Member

@csenet csenet commented Oct 6, 2023

自動運転部分をモノリシックなサービスで実装するため、アーキテクチャ図を更新

@csenet csenet requested a review from kienn-HCl October 6, 2023 09:07
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 6, 2023
@csenet csenet added backend バックエンド関連 documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Oct 6, 2023
@kienn-HCl
Copy link
Collaborator

これEventHandlerって何してるんだっけ?
エッジデバイスからの通信をMQTTHandlerにまとめるようにしたっぽく見えるけどそれならEventHandlerもういらないんじゃない

@github-actions github-actions bot removed the backend バックエンド関連 label Oct 8, 2023
@csenet
Copy link
Member Author

csenet commented Oct 8, 2023

@kienn-HCl
指摘ありがとう
確かに EventHandler必要ないね、修正しておいた

Copy link
Collaborator

@kienn-HCl kienn-HCl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほかは良さそう
LGTM!

@csenet csenet merged commit 5063cd9 into main Oct 9, 2023
@csenet csenet deleted the update-archtecture branch October 9, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants