Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for multicaster #169

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

add tests for multicaster #169

wants to merge 6 commits into from

Conversation

otariidae
Copy link

ref #142

とりあえず議論の叩き台としてconnect_senderとconnect_receiver単体のテストを作成

@otariidae otariidae requested a review from Azuki-bar October 24, 2022 16:09
@otariidae otariidae marked this pull request as draft October 24, 2022 16:18
@otariidae otariidae marked this pull request as ready for review October 24, 2022 16:24
@otariidae
Copy link
Author

otariidae commented Oct 24, 2022

理想的な挙動に寄せたので現状はテスト落ちている

sender_socket がないとき connect_num がインクリメントされないのって正しい挙動?

@ruu413
Copy link

ruu413 commented Oct 28, 2022

senderを繋ぐ前にconnect_receiverの要求がきた場合
Websocketのreceiver通信を保持しておき、senderの通信が来た時に一斉にconnect_receiver命令をreceiverに送る
connect_numは繋ぐ命令を送る時にインクリメント
接続を切るときはconnect_numはデクリメントしない(累積数を見たいため)

@Azuki-bar Azuki-bar requested a review from ruu413 October 30, 2022 11:46
Copy link
Member

@Azuki-bar Azuki-bar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

何やっているか分からないけどテスト実装していそうだしヨシ

@otariidae otariidae mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants