削除するレースを配列で指定するよう変更 #297
Merged
削除するレースを配列で指定するよう変更 #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azuki-bar
requested changes
Nov 12, 2022
proto/spec/v1/userdata.proto
Outdated
| @@ -258,7 +258,7 @@ message EditRaceResponse {} | |||
|
|
|||
| message DeleteRaceResultRequest { | |||
| // 対象を指定するため必須 | |||
| uint32 id = 1 [(validate.rules).uint32.gte = 1]; | |||
| repeated uint32 id = 1; | |||
There was a problem hiding this comment.
あ！！！！！！伝達に不備がありました！！！！！！！
削除対象の馬を配列で指定したいです！！！！！！
There was a problem hiding this comment.
馬はどう指定するのがいいですか？IDとか馬番とか
There was a problem hiding this comment.
Registerに揃えてもらえると嬉しいです
repeated RaceDetail.Member members;
There was a problem hiding this comment.
結果まるごと吹き飛ばすと、登録できた馬と登録できていない馬があるレースで二重に削除することになることに気が付きました
There was a problem hiding this comment.
上追記ですが、レース結果の編集はレース結果のみではなく、それぞれの履歴に追記する作業や勝利数のカウントなどもしているからです
github-actions
bot
added
the
documentation
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #296