feature(provider): allow thread tombstoning and restoration #885
+133
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nperez0111
reviewed
Dec 9, 2024
| @@ -17,6 +19,15 @@ const defaultDeleteCommentOptions: DeleteCommentOptions = { | |||
| deleteThread: false, | |||
| } | |||
|
|
|||
| const defaultGetThreadsOptions: GetThreadsOptions = { | |||
| types: ['undeleted'], | |||
There was a problem hiding this comment.
undeleted isn't a word and doesn't sound right.
How about archived & not archived. Don't need two states, when people get, it should only ever be not archived. And asking for archived means you want archived too.
Like includeArchived?: true
There was a problem hiding this comment.
Or includeDeleted if you wanna stick to that naming
There was a problem hiding this comment.
I'd like to use the types as you can control what you want to get this way, but I'm totally okay with renaming the types.
I used an enum + called them archived and unarchived for now.
nperez0111
previously approved these changes
Dec 9, 2024
nperez0111
reviewed
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request to
packages/providerintroduces several enhancements and new features related to thread management in theTiptapCollabProviderclass. The changes include the addition of new options for handling threads, improvements to thread deletion and restoration, and updates to the type definitions.Enhancements to thread management:
packages/provider/src/TiptapCollabProvider.ts: Added new optionsDeleteThreadOptionsandGetThreadsOptionsto control the output and deletion of threads. ThegetThreadsmethod now accepts anoptionsparameter to filter threads based on their deletion status. [1] [2]packages/provider/src/TiptapCollabProvider.ts: Introduced therestoreThreadmethod to restore deleted threads by setting thedeletedAtproperty tonull.packages/provider/src/TiptapCollabProvider.ts: Updated thedeleteThreadmethod to support soft deletion (marking as deleted) and forceful deletion of threads and their comments based on the provided options.Type definition updates:
packages/provider/src/types.ts: AddeddeletedAtproperty to theTCollabThreadtype to indicate the deletion status of a thread.packages/provider/src/types.ts: Defined new typesDeleteThreadOptionsandGetThreadsOptionsto support the new options in thread management methods.