Prevent setTimeout buildup during frequent document updates #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When making many edits to the same document within the disconnectTimeout window (1000ms by default), it's possible to stack a large number of redundant setTimeout calls. This tracks and clears any pending Timeouts when new hooks are fired against the same document.
|
@janthurau any rough idea when this might be able to be reviewed? it's currently a blocking leak for us, but would prefer not to deploy a fork for too long/at all if avoidable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #854
When making many edits to the same document within the disconnectTimeout window (1000ms by default), it's possible to stack a large number of redundant setTimeout calls. This tracks and clears any pending Timeouts when new hooks are fired against the same document.
in the case of afterStoreDocument, we immediately resolve the promise so that outstanding hooks complete. In the case of onDisconnect, we simply clear the timeout, since we'll set a new delayed disconnect call.