Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open a conference in a new tab #79

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

henrybrink
Copy link
Contributor

This change is introducing the issue desribed in #78

@SergioComeron
Copy link
Member

Hi @henrybrink ,
I'm testing your branch.
I've observed that when enter to the session in a new tab the avatars are not visible. However with the same configuration when opening it embedded, the avatars are seen. The same thing happens to you in your tests?
new tab:
tab
embedded:
iframe

@henrybrink
Copy link
Contributor Author

Yes @SergioComeron,
Jitsi seems to not support passing a avatarURL via the URL-Parameters, but the documentation about this is not really complete. I tried to append the URL via "userInfo.avatarURL", but this did not work for me. Maybe this should be included in the hint in the settings for the selection which methods are available for the user to open the conference in.

@henrybrink
Copy link
Contributor Author

While Jitsi really seems to have no support passing the url for the avatar via the URL, it is however supported via the JWT-Token, so when an application is using JWT the avatar will displayed in the conference regardless of the mode the user is viewing the conference. The avatar will even get loaded, when the Server is not accepting the JWT-Token, like meet.jit.si, but then the user can't join the room because of the invalid authentication.

@SergioComeron
Copy link
Member

Hi @henrybrink ,
all the tests that I have been doing to pass the avatar through the jwt token so far have not been successful and I have never been able to display the avatar via url. Did you get it?

@SergioComeron
Copy link
Member

Sorry,
I just saw that the problem is with access permissions to the images that I use as an avatar.

@henrybrink
Copy link
Contributor Author

Okay, no problem. I also had some issues while testing this.

@aczerzuh
Copy link
Contributor

Hi, is there any update to this PR? Does anything need to be implemented in order to be accepted into the main repo? In our case we need that feature cause our weblogin has a CSP rule which blocks the iframe rendering.
Best wishes,
adrian

@SergioComeron
Copy link
Member

hi aczerzuh,
To open the session in a new tab and not be embedded, it would be necessary to pass all the parameters through the url. In the last revisions that I have made about this, this option does not allow us to pass some of the parameters that we use in the sessions. This would be the reason why we don't implement the option to open the session in another tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants