Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging and config with negex bug fix #89

Merged
merged 10 commits into from
Oct 9, 2023

Conversation

jenniferjiangkells
Copy link
Member

@jenniferjiangkells jenniferjiangkells commented Oct 2, 2023

CHANGES

  • Improved logging
  • Configure negex through config file under general
  • Pass config file location in NoteProcessor init (as opposed to being in same folder as models, although will still default to that)

FIXES:

  • Negex bug: distinguish between None and False options
  • Algorithm: Historic concept with no conversion match is returned as is

@jenniferjiangkells jenniferjiangkells added the type: bug Something isn't working label Oct 2, 2023
@jenniferjiangkells jenniferjiangkells self-assigned this Oct 2, 2023
@jenniferjiangkells jenniferjiangkells changed the base branch from master to dev October 5, 2023 16:38
@jenniferjiangkells jenniferjiangkells changed the base branch from dev to master October 6, 2023 10:08
@jenniferjiangkells jenniferjiangkells force-pushed the bug-fix/negex-config-and-improve-logging branch from 7920df1 to 4f0b45f Compare October 6, 2023 10:31
@jenniferjiangkells jenniferjiangkells changed the title Bug fix and improve logging Improve logging and config with negex bug fix Oct 6, 2023
@jenniferjiangkells jenniferjiangkells merged commit 9fdaf9c into master Oct 9, 2023
1 check passed
@jenniferjiangkells jenniferjiangkells deleted the bug-fix/negex-config-and-improve-logging branch October 10, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant