Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for failure of media component derivative creation #1137

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

barbarahui
Copy link
Collaborator

@barbarahui barbarahui commented Oct 17, 2024

@amywieliczka As we discussed, the updates in this PR set the media component to havemimetype=None and path=None by default. We then check to see if the component path is set, and don't set record['media'] on the record unless it is. This essentially restores the old behavior of the content harvester.

I think that if we instead added the incomplete media field to the index, e.g.:

"media": {
    'mimetype': None,
    'path': None,
    'format': "image"
}

then this would get through to the hosted-simple-image template in the frontend based on the fact that it's a hosted image. Then this line would cause an error because item.contentFile.titleSources was empty:

https://github.com/ucldc/public_interface/blob/main/calisphere/templates/calisphere/objectViewer/hosted-simple-image.html#L33

Or maybe this line would error before that:

https://github.com/ucldc/public_interface/blob/main/calisphere/record.py#L14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant