Allow for failure of media component derivative creation #1137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amywieliczka As we discussed, the updates in this PR set the media component to have
mimetype=None
andpath=None
by default. We then check to see if the componentpath
is set, and don't setrecord['media']
on the record unless it is. This essentially restores the old behavior of the content harvester.I think that if we instead added the incomplete
media
field to the index, e.g.:then this would get through to the hosted-simple-image template in the frontend based on the fact that it's a hosted image. Then this line would cause an error because
item.contentFile.titleSources
was empty:https://github.com/ucldc/public_interface/blob/main/calisphere/templates/calisphere/objectViewer/hosted-simple-image.html#L33
Or maybe this line would error before that:
https://github.com/ucldc/public_interface/blob/main/calisphere/record.py#L14