Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One RIKOLTI_DATA to rule them all #1121

Merged
merged 12 commits into from
Oct 8, 2024
Merged

One RIKOLTI_DATA to rule them all #1121

merged 12 commits into from
Oct 8, 2024

Conversation

amywieliczka
Copy link
Collaborator

This PR:

  • Deprecates VERNACULAR_DATA, MAPPED_DATA, WITH_CONTENT_URLS_DATA, and MERGED_DATA environment variables in favor of RIKOLTI_DATA.
  • Updates CONTENT_ROOT to RIKOLTI_CONTENT
  • Adds a python -m utils.s3copy utility that takes an s3 URI & a local filesystem path to pull down to the local filesystem some arbitrary s3 folder, maintaining relative paths.

Copy link
Collaborator

@barbarahui barbarahui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Yeah, I didn't ever make use of the finer distinction that used to exist between the various data locations env vars.

And in the darkness bind them!

@amywieliczka amywieliczka merged commit 4f584a8 into main Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants