CTP-3412 & CTP-3413 Create overrides for ECs & SORAs #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspark21
reviewed
Oct 3, 2024
aspark21
reviewed
Oct 7, 2024
| * @param ec $ec The EC extension. | ||
| * @return void | ||
| */ | ||
| protected function apply_ec_extension(ec $ec): void { |
There was a problem hiding this comment.
just noting that if we need to implement this per activity, the other pull requests allowing push would only be providing partial support and would need follow up story to implement this in each
There was a problem hiding this comment.
Yes, that's correct, and the apply_sora_extension() function too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployed to 44-clc.
Not testable at the moment. It shouldn't break the plugin as the new code is not called anywhere.