3 Migrate output callbacks to hooks #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate before_standard_top_of_body_html() to a hook for Moodle 4.4 (see MDL-81144).
aydevworks
requested changes
Jul 4, 2024
There was a problem hiding this comment.
I think the code is fine, just a few warnings in the GHA results. @leonstr Could you please have a look? Thanks!
e.g. https://github.com/ucl-isd/moodle-local_examguard/actions/runs/9791801971/job/27041378745
| // | ||
| // You should have received a copy of the GNU General Public License | ||
| // along with Moodle. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
There was a problem hiding this comment.
Looks like missing defined('MOODLE_INTERNAL') || die();
|
@aydevworks Thanks for the feedback, I've added fixes for these warnings. Can you squash this into the original commit? Or let me know if you want me to submit a new PR. |
|
Don’t worry about it, I’ll squash when merging once we finalise 4.4 being prod ready |
aspark21
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate before_standard_top_of_body_html() to a hook for Moodle 4.4 (see MDL-81144).
Proposed fix for issue #3 . For this the plugin would require Moodle 4.4 or later.