CTP-4088 Marker view #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonstr
reviewed
Nov 22, 2024
leonstr
reviewed
Nov 25, 2024
leonstr
reviewed
Nov 27, 2024
Reduce duplicate code and reuse the same template for feedback and marking.
leonstr
reviewed
Dec 2, 2024
|
Hi both, i want to get this right so lets hang and go through what should be: static / called by self:: before i make any further commits. I'm not a php expert, and value both your opinions so i can get better at this and know in future. |
aspark21
reviewed
Dec 3, 2024
leonstr
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If i have a user role where the architype is editingteacher, show me summative assessments that i need to add feedback for.